From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: James Hogan <james.hogan@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] MIPS: cpu: Convert MIPS_CPU_* defs to (1ull << x)
Date: Wed, 13 May 2015 20:22:01 +0300 [thread overview]
Message-ID: <55538839.1010908@cogentembedded.com> (raw)
In-Reply-To: <1431530234-32460-3-git-send-email-james.hogan@imgtec.com>
Hello.
On 05/13/2015 06:17 PM, James Hogan wrote:
> The MIPS_CPU_* definitions have now filled the first 32-bits, and are
> getting longer since they're written in hex without zero padding. Adding
> my 8 extra MIPS_CPU_* definitions which I haven't upstreamed yet this is
> getting increasingly ugly as the comments get shifted progressively to
> the right. Its also error prone, and I've seen this cause mistakes on 3
> separate occasions now, not helped by it being a conflict hotspot.
> Convert all the MIPS_CPU_* definitions to the form (1ull << x). Humans
> are better at incrementing than shifting.
I'm suggesting to use BIT_ULL() then.
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
WBR, Sergei
prev parent reply other threads:[~2015-05-13 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:17 [PATCH 0/2] MIPS: cpu: Clean up MIPS_CPU_* definitions James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-13 15:17 ` [PATCH 1/2] MIPS: cpu: Alter MIPS_CPU_* definitions to fill gap James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-15 19:14 ` Ralf Baechle
2015-05-16 1:42 ` Maciej W. Rozycki
2015-05-13 15:17 ` [PATCH 2/2] MIPS: cpu: Convert MIPS_CPU_* defs to (1ull << x) James Hogan
2015-05-13 15:17 ` James Hogan
2015-05-13 15:38 ` Ezequiel Garcia
2015-05-13 16:01 ` James Hogan
2015-05-13 16:01 ` James Hogan
2015-05-13 17:22 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55538839.1010908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox