From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Cc: linaro-kernel@lists.linaro.org,
Thomas Gleixner <tglx@linutronix.de>,
James Hogan <james.hogan@imgtec.com>,
Andrew Bresticker <abrestic@chromium.org>,
Qais Yousef <qais.yousef@imgtec.com>,
Jason Cooper <jason@lakedaemon.net>,
Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: [PATCH 07/14] MIPS/cevt-r4k: Migrate to new 'set-state' interface
Date: Mon, 06 Jul 2015 23:29:50 +0300 [thread overview]
Message-ID: <559AE53E.6070909@cogentembedded.com> (raw)
In-Reply-To: <559AC7F7.9080600@cogentembedded.com>
On 07/06/2015 09:24 PM, Sergei Shtylyov wrote:
>>> Migrate cevt-4k driver to the new 'set-state' interface provided by
>>> clockevents core, the earlier 'set-mode' interface is marked obsolete
>>> now.
>>> This also enables us to implement callbacks for new states of clockevent
>>> devices, for example: ONESHOT_STOPPED.
>>> We weren't doing anything in the ->set_mode() callback. So, this patch
>>> doesn't provide any set-state callbacks.
>> The code in __clockevents_switch_state() looks like it's going to oops as
>> you're not implementing set_state_oneshot()...
> In fact, clockevents_sanity_check() should return -EINVAL in this case,
> and so the kernel crash even earlier, duyr to BUG_ON() in
> clockevents_register_device().
tglx has turned my attention the pre-requisite patch, and I have finally
found it in the archives. I'm now OK with the patches I considered broken.
WBR, Sergei
next prev parent reply other threads:[~2015-07-06 20:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 11:11 [PATCH 00/14] MIPS: Migrate clockevent drivers to 'set-state' Viresh Kumar
2015-07-06 11:11 ` [PATCH 01/14] MIPS/alchemy/time: Migrate to new 'set-state' interface Viresh Kumar
2015-07-06 19:01 ` Sergei Shtylyov
2015-07-06 19:37 ` Manuel Lauss
2015-07-06 11:11 ` [PATCH 02/14] MIPS/jazz/timer: " Viresh Kumar
2015-07-06 19:03 ` Sergei Shtylyov
2015-07-06 11:11 ` [PATCH 03/14] MIPS/jz4740/time: " Viresh Kumar
2015-07-06 11:11 ` [PATCH 04/14] MIPS/cevt-bcm1480: " Viresh Kumar
2015-07-06 11:11 ` [PATCH 05/14] MIPS/cevt-ds1287: " Viresh Kumar
2015-07-06 11:11 ` [PATCH 06/14] MIPS/cevt-gt641xx: " Viresh Kumar
2015-07-06 11:11 ` [PATCH 07/14] MIPS/cevt-r4k: " Viresh Kumar
2015-07-06 18:11 ` Sergei Shtylyov
2015-07-06 18:24 ` Sergei Shtylyov
2015-07-06 20:29 ` Sergei Shtylyov [this message]
2015-07-06 11:11 ` [PATCH 08/14] MIPS/cevt-sb1250: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 09/14] MIPS/cevt-txx9: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 10/14] MIPS/loongson64/timer: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 11/14] MIPS/loongsoon32/time: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 12/14] MIPS/ralink/rt3352: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 13/14] MIPS/sgi-ip27/timer: " Viresh Kumar
2015-07-06 11:12 ` [PATCH 14/14] MIPS/sni/time: " Viresh Kumar
2015-07-06 20:52 ` [PATCH 00/14] MIPS: Migrate clockevent drivers to 'set-state' Sergei Shtylyov
2015-07-07 5:38 ` Viresh Kumar
2015-07-13 2:51 ` Viresh Kumar
2015-07-27 9:25 ` Ralf Baechle
2015-07-27 9:31 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559AE53E.6070909@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=abrestic@chromium.org \
--cc=daniel.lezcano@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=jason@lakedaemon.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-mips@linux-mips.org \
--cc=qais.yousef@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox