Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Alban Bedel <albeu@free.fr>,
	linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Cc: Andrew Bresticker <abrestic@chromium.org>,
	Qais Yousef <qais.yousef@imgtec.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Gabor Juhos <juhosg@openwrt.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API
Date: Sun, 09 Aug 2015 14:21:11 +0200	[thread overview]
Message-ID: <55C745B7.3040002@hauke-m.de> (raw)
In-Reply-To: <1429446604-15403-6-git-send-email-albeu@free.fr>

On 04/19/2015 02:30 PM, Alban Bedel wrote:
> Make the code simpler and open the way for device tree clocks.
> 
> Signed-off-by: Alban Bedel <albeu@free.fr>
> ---
>  arch/mips/Kconfig       |  1 +
>  arch/mips/ath79/clock.c | 29 ++---------------------------
>  2 files changed, 3 insertions(+), 27 deletions(-)
> 

I think this should be send at least to stable 4.1, because it fixes a
linking problem we are seeing in OpenWrt.

ath79 does not export clk_set_rate() and clk_round_rate(), but some
drivers are using it and they are not using the inline dummy method,
because CONFIG_HAVE_CLK is set for ath79.

ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined!
ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined!

Hauke

  reply	other threads:[~2015-08-09 12:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19 12:29 [PATCH v2 0/5] MIPS: ath79: Various small fix to prepare OF support Alban Bedel
2015-04-19 12:30 ` [PATCH v2 1/5] MIPS: ath79: Enable ZBOOT support Alban Bedel
2015-04-19 12:30 ` [PATCH v2 2/5] MIPS: ath79: Add a missing new line in log message Alban Bedel
2015-04-19 12:30 ` [PATCH v2 3/5] MIPS: ath79: Correctly name the defines for the PLL_FB register Alban Bedel
2015-04-19 12:30 ` [PATCH v2 4/5] MIPS: ath79: Improve the DDR controller interface Alban Bedel
2015-04-19 12:30 ` [PATCH v2 5/5] MIPS: ath79: Use the common clk API Alban Bedel
2015-08-09 12:21   ` Hauke Mehrtens [this message]
2015-08-19 21:03     ` Ralf Baechle
2015-08-19 21:10       ` Ralf Baechle
2015-08-19 21:10         ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C745B7.3040002@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=abrestic@chromium.org \
    --cc=albeu@free.fr \
    --cc=juhosg@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=qais.yousef@imgtec.com \
    --cc=ralf@linux-mips.org \
    --cc=ryazanov.s.a@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox