From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Hauke Mehrtens <hauke@hauke-m.de>, ralf@linux-mips.org
Cc: blogic@openwrt.org, linux-mips@linux-mips.org,
Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Subject: Re: [PATCH 01/15] MIPS: lantiq: add locking for PMU register and check status afterwards
Date: Thu, 29 Oct 2015 14:19:16 +0300 [thread overview]
Message-ID: <563200B4.7090105@cogentembedded.com> (raw)
In-Reply-To: <1446071865-21936-2-git-send-email-hauke@hauke-m.de>
Hello.
On 10/29/2015 1:37 AM, Hauke Mehrtens wrote:
> From: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
>
> From: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Hm... why twice?
> The PMU register are accesses in a non atomic way and they could be
Accessed?
> accesses by different threads simultaneously, which could cause
Accessed?
> problems this patch adds locking around the PMU registers. In
> addition it is now also waited till the PMU is actually deactivated.
Perhaps "we now also wait"?
> Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-10-29 11:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 22:37 [PATCH 00/15] MIPS: lantiq: add clock and PMU support for new SoCs Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 01/15] MIPS: lantiq: add locking for PMU register and check status afterwards Hauke Mehrtens
2015-10-29 11:19 ` Sergei Shtylyov [this message]
2015-10-29 19:15 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 02/15] MIPS: lantiq: add support for setting PMU register on AR10 and GRX390 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 03/15] MIPS: lantiq: rename CGU_SYS_VR9 register Hauke Mehrtens
2015-10-29 19:15 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 04/15] MIPS: lantiq: fix pp32 clock on vr9 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 05/15] MIPS: lantiq: add clock detection for grx390 and ar10 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 06/15] MIPS: lantiq: deactivate most of the devices by default Hauke Mehrtens
2015-10-29 6:18 ` John Crispin
2015-10-28 22:37 ` [PATCH 07/15] MIPS: lantiq: add PMU bits for USB and SDIO devices Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 08/15] MIPS: lantiq: add pmu bits for ar10 and grx390 Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 09/15] MIPS: lantiq: add support for gphy firmware loading " Hauke Mehrtens
2015-10-29 19:16 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 10/15] MIPS: lantiq: add SoC detection " Hauke Mehrtens
2015-10-29 19:17 ` [PATCH please merge into original " Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 11/15] MIPS: lantiq: add clock for mei driver Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 12/15] MIPS: lantiq: add 1e103100.deu clock Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 13/15] MIPS: lantiq: add misc clocks Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 14/15] MIPS: lantiq: add support for xRX220 SoC Hauke Mehrtens
2015-10-28 22:37 ` [PATCH 15/15] MIPS: lantiq: fix check for return value of request_mem_region() Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563200B4.7090105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=hauke.mehrtens@lantiq.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox