From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 03 Nov 2015 17:42:52 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:63075 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010433AbbKCQmtYTq0A (ORCPT ); Tue, 3 Nov 2015 17:42:49 +0100 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Websense Email Security Gateway with ESMTPS id 7BDAD802C06D5; Tue, 3 Nov 2015 16:42:36 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 3 Nov 2015 16:42:39 +0000 Received: from [192.168.154.64] (192.168.154.64) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Tue, 3 Nov 2015 16:42:38 +0000 Subject: Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c To: Tony Wu , , References: <20151103163943.GA49024@yggdrasil> From: Markos Chandras Message-ID: <5638E3FE.2010503@imgtec.com> Date: Tue, 3 Nov 2015 16:42:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151103163943.GA49024@yggdrasil> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.64] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49823 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 11/03/2015 04:39 PM, Tony Wu wrote: > Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add > MIPS R6 support to /proc/cpuinfo), mips1 should be tested against > cpu_has_mips_1, not cpu_has_mips_r1. > > Signed-off-by: Tony Wu > Cc: Markos Chandras > > diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c > index 211fcd4..3417ce0 100644 > --- a/arch/mips/kernel/proc.c > +++ b/arch/mips/kernel/proc.c > @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v) > } > > seq_printf(m, "isa\t\t\t:"); > - if (cpu_has_mips_r1) > + if (cpu_has_mips_1) > seq_printf(m, " mips1"); > if (cpu_has_mips_2) > seq_printf(m, "%s", " mips2"); > Good catch. Might worth adding CC:stable #v4.0+ as well -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:63075 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010433AbbKCQmtYTq0A (ORCPT ); Tue, 3 Nov 2015 17:42:49 +0100 Subject: Re: [PATCH] MIPS: kernel: proc: Fix typo in proc.c References: <20151103163943.GA49024@yggdrasil> From: Markos Chandras Message-ID: <5638E3FE.2010503@imgtec.com> Date: Tue, 3 Nov 2015 16:42:38 +0000 MIME-Version: 1.0 In-Reply-To: <20151103163943.GA49024@yggdrasil> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Tony Wu , linux-mips@linux-mips.org, ralf@linux-mips.org Message-ID: <20151103164238.VAbuZhGz1PYjzuWJ-fhYddEOKLt5sVepZVUkrWN981s@z> On 11/03/2015 04:39 PM, Tony Wu wrote: > Fix typo introduced in commit 515a6393 (MIPS: kernel: proc: Add > MIPS R6 support to /proc/cpuinfo), mips1 should be tested against > cpu_has_mips_1, not cpu_has_mips_r1. > > Signed-off-by: Tony Wu > Cc: Markos Chandras > > diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c > index 211fcd4..3417ce0 100644 > --- a/arch/mips/kernel/proc.c > +++ b/arch/mips/kernel/proc.c > @@ -83,7 +83,7 @@ static int show_cpuinfo(struct seq_file *m, void *v) > } > > seq_printf(m, "isa\t\t\t:"); > - if (cpu_has_mips_r1) > + if (cpu_has_mips_1) > seq_printf(m, " mips1"); > if (cpu_has_mips_2) > seq_printf(m, "%s", " mips2"); > Good catch. Might worth adding CC:stable #v4.0+ as well -- markos