Re: [PATCH 4/4] arch: mips: lantiq: disable xbar fpi burst mode

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 11/4/2015 3:14 PM, John Crispin wrote:

> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>   arch/mips/lantiq/xway/sysctrl.c |   41 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 41 insertions(+)
>
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index 2b15491..9147c4b 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
[...]
> @@ -179,6 +187,16 @@ static void pci_ext_disable(struct clk *clk)
>   	ltq_cgu_w32((1 << 31) | (1 << 30), pcicr);
>   }
>
> +static void xbar_fpi_burst_disable(void)
> +{
> +	u32 reg;
> +
> +	/* bit 1 as 1 --burst; bit 1 as 0 -- single */
> +	reg = xbar_r32(XBAR_ALWAYS_LAST);
> +	reg &= ~XBAR_FPI_BURST_EN;
> +	xbar_w32(reg, XBAR_ALWAYS_LAST);
> +}
> +
>   /* enable a clockout source */
>   static int clkout_enable(struct clk *clk)
>   {
> @@ -328,6 +346,26 @@ void __init ltq_soc_init(void)
>   	if (!pmu_membase || !ltq_cgu_membase || !ltq_ebu_membase)
>   		panic("Failed to remap core resources");
>
> +

    Why two empty lines?

> +	if (of_machine_is_compatible("lantiq,vr9")) {
> +		struct resource res_xbar;
> +		struct device_node *np_xbar =
> +		of_find_compatible_node(NULL, NULL,
> +			"lantiq,xbar-xway");

    This needs to be indented more to the right and empty line needs to be 
added afterwards.

> +		if (!np_xbar)
> +			panic("Failed to load xbar nodes from devicetree");
> +		if (of_address_to_resource(np_pmu, 0, &res_xbar))
> +			panic("Failed to get xbar resources");
> +		if (request_mem_region(res_xbar.start, resource_size(&res_xbar),
> +			res_xbar.name) < 0)
> +			panic("Failed to get xbar resources");
> +
> +		ltq_xbar_membase = ioremap_nocache(res_xbar.start,
> +		resource_size(&res_xbar));

    This line needs to be indented more to the right.

[...]

MBR, Sergei