From: John Crispin <blogic@openwrt.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] MIPS: ralink: Make reset_control_ops const
Date: Thu, 25 Feb 2016 10:51:30 +0100 [thread overview]
Message-ID: <56CECEA2.2050904@openwrt.org> (raw)
In-Reply-To: <1456393547-28030-3-git-send-email-p.zabel@pengutronix.de>
On 25/02/2016 10:45, Philipp Zabel wrote:
> The reset_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/ralink/reset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/reset.c b/arch/mips/ralink/reset.c
> index ee117c4..09ccdd1 100644
> --- a/arch/mips/ralink/reset.c
> +++ b/arch/mips/ralink/reset.c
> @@ -61,7 +61,7 @@ static int ralink_reset_device(struct reset_controller_dev *rcdev,
> return ralink_deassert_device(rcdev, id);
> }
>
> -static struct reset_control_ops reset_ops = {
> +static const struct reset_control_ops reset_ops = {
> .reset = ralink_reset_device,
> .assert = ralink_assert_device,
> .deassert = ralink_deassert_device,
>
prev parent reply other threads:[~2016-02-25 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 9:45 [PATCH 0/2] MIPS: Make reset_control_ops const Philipp Zabel
2016-02-25 9:45 ` [PATCH 1/2] MIPS: lantiq: " Philipp Zabel
2016-02-25 9:51 ` John Crispin
2016-02-25 9:45 ` [PATCH 2/2] MIPS: ralink: " Philipp Zabel
2016-02-25 9:51 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CECEA2.2050904@openwrt.org \
--to=blogic@openwrt.org \
--cc=kernel@pengutronix.de \
--cc=linux-mips@linux-mips.org \
--cc=p.zabel@pengutronix.de \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox