From: David Daney <ddaney.cavm@gmail.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/4] MIPS: Add and use watch register field definitions
Date: Tue, 01 Mar 2016 14:27:30 -0800 [thread overview]
Message-ID: <56D61752.7020804@gmail.com> (raw)
In-Reply-To: <1456870779-21007-5-git-send-email-james.hogan@imgtec.com>
On 03/01/2016 02:19 PM, James Hogan wrote:
> The files watch.c and ptrace.c contain various magic masks for
> WatchLo/WatchHi register fields. Add some definitions to mipsregs.h for
> these registers and make use of them in both watch.c and ptrace.c,
> hopefully making them more readable.
>
> Signed-off-by: James Hogan<james.hogan@imgtec.com>
Seems sane,
Reviewed-by: David Daney <david.daney@cavium.com>
> Cc: Ralf Baechle<ralf@linux-mips.org>
> Cc:linux-mips@linux-mips.org
> ---
> arch/mips/include/asm/mipsregs.h | 18 ++++++++++
> arch/mips/kernel/ptrace.c | 7 ++--
> arch/mips/kernel/watch.c | 74 ++++++++++++++++++++++------------------
> 3 files changed, 63 insertions(+), 36 deletions(-)
>
[...]
prev parent reply other threads:[~2016-03-01 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:19 [PATCH 0/4] MIPS: Watchpoint fixes and cleanups James Hogan
2016-03-01 22:19 ` James Hogan
2016-03-01 22:19 ` [PATCH 1/4] MIPS: Fix watchpoint restoration James Hogan
2016-03-01 22:19 ` James Hogan
2016-03-01 22:19 ` [PATCH 2/4] MIPS: Enable ptrace hw watchpoints on MIPS R6 James Hogan
2016-03-01 22:19 ` James Hogan
2016-03-01 22:19 ` [PATCH 3/4] MIPS: Add and use CAUSEF_WP definition James Hogan
2016-03-01 22:19 ` James Hogan
2016-03-01 22:19 ` [PATCH 4/4] MIPS: Add and use watch register field definitions James Hogan
2016-03-01 22:19 ` James Hogan
2016-03-01 22:27 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D61752.7020804@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox