From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Song Liu <song@kernel.org>, Luis Chamberlain <mcgrof@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory
Date: Tue, 14 Feb 2023 08:22:02 +0100 [thread overview]
Message-ID: <59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org> (raw)
In-Reply-To: <20230214005400.17137-1-rdunlap@infradead.org>
Hi Randy,
On 14/2/23 01:54, Randy Dunlap wrote:
> Correct the struct's field/member name from mod_mem to mem.
>
> Fixes this build error:
> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
> 643 | v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>
> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
On which tree is your patch based?
fatal: ambiguous argument '2ece476a2346': unknown revision or path not
in the working tree.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Song Liu <song@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
> Has this already been fixed?
>
> arch/mips/kernel/vpe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
> --- a/arch/mips/kernel/vpe.c
> +++ b/arch/mips/kernel/vpe.c
> @@ -640,7 +640,7 @@ static int vpe_elfload(struct vpe *v)
> layout_sections(&mod, hdr, sechdrs, secstrings);
> }
>
> - v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
> + v->load_addr = alloc_progmem(mod.mem[MOD_TEXT].size);
> if (!v->load_addr)
> return -ENOMEM;
>
next prev parent reply other threads:[~2023-02-14 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 0:54 [PATCH] module: fix MIPS module_layout -> module_memory Randy Dunlap
2023-02-14 7:22 ` Philippe Mathieu-Daudé [this message]
2023-02-14 16:52 ` Randy Dunlap
2023-02-17 11:58 ` Thomas Bogendoerfer
2023-02-17 12:35 ` Philippe Mathieu-Daudé
2023-02-17 15:53 ` Randy Dunlap
2023-02-21 21:39 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org \
--to=philmd@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rdunlap@infradead.org \
--cc=song@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).