From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Youling Tang <tangyouling@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Jinyang He <hejinyang@loongson.cn>
Subject: Re: [PATCH] MIPS: Fix cmdline "mem=" parameter parsing
Date: Tue, 20 Apr 2021 09:05:02 +0800 [thread overview]
Message-ID: <5d4d31aa-7fe5-bf8d-1d77-a1605f0c2793@flygoat.com> (raw)
In-Reply-To: <1618829425-11873-1-git-send-email-tangyouling@loongson.cn>
在 2021/4/19 18:50, Youling Tang 写道:
> This problem may only occur on NUMA platforms. When machine start with the
> "mem=" parameter on Loongson64, it cannot boot. When parsing the "mem="
> parameter, first remove all RAM, and then add memory through memblock_add(),
> which causes the newly added memory to be located on MAX_NUMNODES.
>
> The solution is to add the current "mem=" parameter range to the memory area
> of the corresponding node, instead of adding all of it to the MAX_NUMNODES
> node area. Get the node number corresponding to the "mem=" parameter range
> through pa_to_nid(), and then add it to the corresponding node through
> memblock_add_node().
>
> Signed-off-by: Jinyang He <hejinyang@loongson.cn>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 279be01..b86e241 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -359,7 +359,7 @@ static int __init early_parse_mem(char *p)
> if (*p == '@')
> start = memparse(p + 1, &p);
>
> - memblock_add(start, size);
> + memblock_add_node(start, size, pa_to_nid(start));
pa_to_nid is not available for all platforms.
Thanks.
- Jiaxun
>
> return 0;
> }
next prev parent reply other threads:[~2021-04-20 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:50 [PATCH] MIPS: Fix cmdline "mem=" parameter parsing Youling Tang
2021-04-19 15:43 ` kernel test robot
2021-04-20 1:05 ` Jiaxun Yang [this message]
2021-04-20 2:16 ` Youling Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4d31aa-7fe5-bf8d-1d77-a1605f0c2793@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=hejinyang@loongson.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tangyouling@loongson.cn \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox