* Re: [PATCH v8 4/9] coredump: add coredump socket
[not found] ` <20250516-work-coredump-socket-v8-4-664f3caf2516@kernel.org>
@ 2025-05-23 0:59 ` Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2025-05-23 0:59 UTC (permalink / raw)
To: Christian Brauner, linux-fsdevel, Jann Horn, Daniel Borkmann,
Kuniyuki Iwashima, Thomas Bogendoerfer, linux-mips
Cc: Eric Dumazet, Oleg Nesterov, David S. Miller, Alexander Viro,
Daan De Meyer, David Rheinsberg, Jakub Kicinski, Jan Kara,
Lennart Poettering, Luca Boccassi, Mike Yuan, Paolo Abeni,
Simon Horman, Zbigniew Jędrzejewski-Szmek, linux-kernel,
netdev, linux-security-module, Alexander Mikhalitsyn
Hi,
On 5/16/25 4:25 AM, Christian Brauner wrote:
> Coredumping currently supports two modes:
>
> ---
> fs/coredump.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++--
> include/linux/net.h | 1 +
> net/unix/af_unix.c | 54 ++++++++++++++++++------
> 3 files changed, 156 insertions(+), 17 deletions(-)
>
[snip]
git a/include/linux/net.h b/include/linux/net.h> index 0ff950eecc6b..139c85d0f2ea 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -81,6 +81,7 @@ enum sock_type {
> #ifndef SOCK_NONBLOCK
> #define SOCK_NONBLOCK O_NONBLOCK
> #endif
> +#define SOCK_COREDUMP O_NOCTTY
>
> #endif /* ARCH_HAS_SOCKET_TYPES */
MIPS sets ARCH_HAS_SOCKET_TYPES so the new define above is not used,
causing:
net/unix/af_unix.c:1152:21: error: 'SOCK_COREDUMP' undeclared (f
irst use in this function); did you mean 'SOCK_RDM'?
--
~Randy
^ permalink raw reply [flat|nested] only message in thread