From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg KH <greg@kroah.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Huacai Chen <chenhc@lemote.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
kvm@vger.kernel.org, linux-mips@vger.kernel.org,
Fuxin Zhang <zhangfx@lemote.com>,
Huacai Chen <chenhuacai@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64
Date: Sun, 9 Aug 2020 19:23:28 +0200 [thread overview]
Message-ID: <5ffc7bb1-8e3f-227a-7ad0-cec5fc32a96a@redhat.com> (raw)
In-Reply-To: <20200809070235.GA1098081@kroah.com>
On 09/08/20 09:02, Greg KH wrote:
>>>> diff --git a/arch/mips/kvm/vz.c b/arch/mips/kvm/vz.c
>>>> index 3932f76..a474578 100644
>>>> --- a/arch/mips/kvm/vz.c
>>>> +++ b/arch/mips/kvm/vz.c
>>>> @@ -29,7 +29,9 @@
>>>> #include <linux/kvm_host.h>
>>>> #include "interrupt.h"
>>>> +#ifdef CONFIG_CPU_LOONGSON64
>>>> #include "loongson_regs.h"
>>>> +#endif
>>> The fix for this should be in the .h file, no #ifdef should be needed in
>>> a .c file.
>> The header file can only be reached when CONFIG_CPU_LOONGSON64 is
>> selected...
>> Otherwise the include path of this file won't be a part of CFLAGS.
> That sounds like you should fix up the path of this file in the
> #include line as well :)
>
There is more #ifdef CONFIG_CPU_LOONGSON64 in arch/mips/kvm/vz.c, and
more #include "loongson_regs.h" in arch/mips. So while I agree with
Greg that this idiom is quite unusual, it seems to be the expected way
to use this header. I queued the patch.
Paolo
next prev parent reply other threads:[~2020-08-09 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 12:50 [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64 Huacai Chen
2020-08-08 15:31 ` Greg KH
2020-08-08 15:35 ` Jiaxun Yang
2020-08-09 7:02 ` Greg KH
2020-08-09 17:23 ` Paolo Bonzini [this message]
2020-08-09 17:38 ` Sasha Levin
2020-08-09 17:45 ` Sasha Levin
2020-08-10 7:44 ` Greg KH
2020-08-10 8:56 ` Paolo Bonzini
2020-08-10 9:03 ` Greg KH
2020-08-10 9:29 ` Jiaxun Yang
2020-08-10 9:31 ` Thomas Bogendoerfer
2020-08-22 18:24 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ffc7bb1-8e3f-227a-7ad0-cec5fc32a96a@redhat.com \
--to=pbonzini@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=greg@kroah.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox