From: Markus Elfring <Markus.Elfring@web.de>
To: Keguang Zhang <keguang.zhang@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
Date: Sun, 28 Jul 2024 11:40:12 +0200 [thread overview]
Message-ID: <624be618-1a1a-422c-85e9-be3e1d182adf@web.de> (raw)
In-Reply-To: <20240726-loongson1-dma-v10-2-31bf095a6fa6@gmail.com>
> This patch adds …
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94
…
> +++ b/drivers/dma/loongson1-apb-dma.c
> @@ -0,0 +1,675 @@
…
> +static int ls1x_dma_resume(struct dma_chan *dchan)
> +{
…
> + spin_lock_irqsave(&chan->vchan.lock, flags);
> + ret = ls1x_dma_start(chan, &chan->curr_lli->phys);
> + spin_unlock_irqrestore(&chan->vchan.lock, flags);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&chan->vchan.lock);”?
https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/spinlock.h#L574
Regards,
Markus
next prev parent reply other threads:[~2024-07-28 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 13:06 [PATCH v10 0/2] Add support for Loongson1 APB DMA Keguang Zhang via B4 Relay
2024-07-26 13:06 ` [PATCH v10 1/2] dt-bindings: dma: Add Loongson-1 " Keguang Zhang via B4 Relay
2024-07-26 13:06 ` [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver Keguang Zhang via B4 Relay
2024-07-27 19:11 ` kernel test robot
2024-07-28 9:40 ` Markus Elfring [this message]
2024-07-29 12:55 ` Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624be618-1a1a-422c-85e9-be3e1d182adf@web.de \
--to=markus.elfring@web.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=keguang.zhang@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox