From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 30 Oct 2014 10:07:05 +0100 (CET) Received: from mout.kundenserver.de ([212.227.126.187]:57453 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27012245AbaJ3JG769yws (ORCPT ); Thu, 30 Oct 2014 10:06:59 +0100 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue004) with ESMTP (Nemesis) id 0MAASz-1XuRrJ1Arp-00BM3L; Thu, 30 Oct 2014 10:06:52 +0100 From: Arnd Bergmann To: Thomas Gleixner Cc: Kevin Cernekee , f.fainelli@gmail.com, jason@lakedaemon.net, ralf@linux-mips.org, lethal@linux-sh.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mbizon@freebox.fr, jogo@openwrt.org, linux-mips@linux-mips.org Subject: Re: [PATCH V2 03/15] genirq: Generic chip: Move irq_reg_{readl,writel} accessors into generic-chip.c Date: Thu, 30 Oct 2014 10:06:51 +0100 Message-ID: <6552163.gt4ABVyYlA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1414635488-14137-1-git-send-email-cernekee@gmail.com> <1414635488-14137-4-git-send-email-cernekee@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:gfzDjLTecc2L7VX+0HAgY1/wdJkjqZy0Zay/zOLZhK+ Vu0K7I+ZdhuxNrAMlbkpvua7VgTqt+8KyXnmN4YcC0WhxrGQkY sz9oKRqbxbNMj7665jbwkg2jqNuW2HJROWVL2PLPH6iEqhjgCp +cAMhwWdNhHfLrVqrCHl3CzxMmO7pni5859GKPVg5K2E/ZYvqX m1nrzDt1Js2pcMnxprF8D/A/CrzS7he5lJh4t0wmnX5aehJ/V8 7lniCt7Aokd8TraRH+/Ei+ibpm9y+vYynXfn2JpzJ7KXrWOJks HAM8SBz4kzZypukJ/a3omRvt74bfs/PmE+XlILmnTeTswEQtw0 VWJu55w0FDlDkzeReqnw= X-UI-Out-Filterresults: notjunk:1; Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43760 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: arnd@arndb.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thursday 30 October 2014 09:43:02 Thomas Gleixner wrote: > > diff --git a/include/linux/irq.h b/include/linux/irq.h > > index 03f48d9..8049e93 100644 > > --- a/include/linux/irq.h > > +++ b/include/linux/irq.h > > @@ -639,13 +639,6 @@ void arch_teardown_hwirq(unsigned int irq); > > void irq_init_desc(unsigned int irq); > > #endif > > > > -#ifndef irq_reg_writel > > -# define irq_reg_writel(val, addr) writel(val, addr) > > -#endif > > -#ifndef irq_reg_readl > > -# define irq_reg_readl(addr) readl(addr) > > -#endif > > - > > Brilliant patch that. > > # git grep -l irq_reg_readl drivers/irqchip/ > drivers/irqchip/irq-atmel-aic.c > drivers/irqchip/irq-atmel-aic5.c > drivers/irqchip/irq-sunxi-nmi.c > drivers/irqchip/irq-tb10x.c Patch 1/15 changes these all. I think it's still broken because patch 2/15 is wrong, but it's not /that/ obviously broken. Arnd