From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Qing Zhang <zhangqing@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh+dt@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@kernel.org>
Cc: devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for Loongson-2K1000
Date: Mon, 28 Jun 2021 19:03:32 +0300 [thread overview]
Message-ID: <697cd16e-7131-95d6-6e0b-1034d493b3ce@gmail.com> (raw)
In-Reply-To: <20210628151330.11952-2-zhangqing@loongson.cn>
Hello!
On 6/28/21 6:13 PM, Qing Zhang wrote:
> The module is now supported, enable it.
>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
>
> v3-v4:
> No change
>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 569e814def83..e31176ac0ac2 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -101,6 +101,15 @@ uart0: serial@1fe00000 {
> no-loopback-test;
> };
>
> + pm: power-controller {
> + device_type = "power management";
> + compatible = "loongson, reset-controller";
No spaces allowed here, AFAIK.
> + reg = <0 0x1fe0700c 0 0x8>,
> + <0 0x1fe07014 0 0x8>,
> + <0 0x1fe07030 0 0x8>;
Better keep those aligned...
> + reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
> + };
> +
[...]
MBR, Sergei
next prev parent reply other threads:[~2021-06-28 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:13 [PATCH v4 1/2] MIPS: Loongson64: Add Loongson-2K1000 reset platform driver Qing Zhang
2021-06-28 15:13 ` [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for Loongson-2K1000 Qing Zhang
2021-06-28 16:03 ` Sergei Shtylyov [this message]
2021-06-29 1:04 ` zhangqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697cd16e-7131-95d6-6e0b-1034d493b3ce@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).