From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Vinod Koul" <vkoul@kernel.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
linux-mips@vger.kernel.org, dmaengine@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 09/59] dma: dma-jz4780: Convert to platform remove callback returning void
Date: Wed, 20 Sep 2023 17:44:34 +0200 [thread overview]
Message-ID: <6fb10313-ac31-f5ed-763f-4424ec502d78@linaro.org> (raw)
In-Reply-To: <20230919133207.1400430-10-u.kleine-koenig@pengutronix.de>
On 19/9/23 15:31, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/dma/dma-jz4780.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-09-20 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 13:31 [PATCH 00/59] dma: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 13:31 ` [PATCH 09/59] dma: dma-jz4780: " Uwe Kleine-König
2023-09-19 13:39 ` Paul Cercueil
2023-09-19 14:48 ` Uwe Kleine-König
2023-09-20 15:44 ` Philippe Mathieu-Daudé [this message]
2023-09-28 7:46 ` [PATCH 00/59] dma: " Vinod Koul
2023-09-28 7:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb10313-ac31-f5ed-763f-4424ec502d78@linaro.org \
--to=philmd@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).