From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79870C4332F for ; Tue, 11 Oct 2022 14:50:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiJKOuC (ORCPT ); Tue, 11 Oct 2022 10:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbiJKOuB (ORCPT ); Tue, 11 Oct 2022 10:50:01 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0562B1D0FA; Tue, 11 Oct 2022 07:49:57 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3DECE660235B; Tue, 11 Oct 2022 15:49:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1665499795; bh=WjWfvO7t5fdyGrI6m+hgGbT3QH4QBKj79I/hqKmON7Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JOT+AnjvhQZ3vD+INlRyJUZGm23CWRspXdxuJNoFNT/2BU3BDi5IDkH2Yrh9cl34H N8tYn0ib9h2NSJZ2wAIfZfryQVLEoNCgFUyUgtoeB3uep2/6DEsQ7yGEO0febOyHvI hMQps4hKjRpiDfHJVubm1kSgDODcE0fxz35XL3pmTQUoBsYWlj52rSQaBN3or/Qysa Nnl5TlEZJvEM/mGOVrA3G338yKAO4fX3D/W0mLbDZJMGmbluyKM/eYT4wVNA1RFmtD w5vR7Uu6LnwTML9dH9/oGV1Cci4KZACKsyC/Ihfwo8y3IRLkhbhb0iRzW5ZY4Zwh1d X736PHBsaUIKg== Message-ID: <74cdcd93-a528-ec8c-0808-0d698b86e47d@collabora.com> Date: Tue, 11 Oct 2022 16:49:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 14/36] pinctrl: mediatek: Add missed header(s) Content-Language: en-US To: Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Kent Gibson , Mauro Carvalho Chehab , Billy Tsai , Thomas Gleixner , Linus Walleij , Mika Westerberg , Chen-Yu Tsai , Claudiu Beznea , Samuel Holland , Horatiu Vultur , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Lad Prabhakar , Phil Edworthy , Krzysztof Kozlowski , Fabien Dessenne , Prathamesh Shete , Basavaraj Natikar , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Thierry Reding , Jonathan Hunter , Patrice Chotard , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Andrew Jeffery , Joel Stanley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Charles Keepax , Richard Fitzgerald , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Andy Shevchenko , Sean Wang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Damien Le Moal , Tony Lindgren , Haojian Zhuang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Andy Gross , Konrad Dybcio , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Emil Renner Berthing , Kunihiko Hayashi , Masami Hiramatsu References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-15-andriy.shevchenko@linux.intel.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221010201453.77401-15-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Il 10/10/22 22:14, Andy Shevchenko ha scritto: > Do not imply that some of the generic headers may be always included. > Instead, include explicitly what we are direct user of. > > While at it, sort headers alphabetically. > > Signed-off-by: Andy Shevchenko > --- > drivers/pinctrl/mediatek/pinctrl-moore.c | 3 +++ > drivers/pinctrl/mediatek/pinctrl-paris.c | 5 +++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c > index 526faaebaf77..9474ada5addb 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-moore.c > +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c > @@ -9,6 +9,9 @@ > */ > > #include > + Apart from this blank line that I deem unnecessary.... Reviewed-by: AngeloGioacchino Del Regno