* [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
@ 2022-11-25 9:26 Anastasia Belova
2022-11-25 14:14 ` Jonas Gorski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Anastasia Belova @ 2022-11-25 9:26 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Anastasia Belova, Jonathan Cameron, Randy Dunlap,
Florian Fainelli, Maxime Bizon, Ralf Baechle, linux-mips,
linux-kernel, lvc-project
Check clk for NULL before calling clk_enable_unlocked where clk
is dereferenced. There is such check in other implementations
of clk_enable.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
---
arch/mips/bcm63xx/clk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index 6e6756e8fa0a..401140cf36d9 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -361,6 +361,9 @@ static struct clk clk_periph = {
*/
int clk_enable(struct clk *clk)
{
+ if (!clk)
+ return;
+
mutex_lock(&clocks_mutex);
clk_enable_unlocked(clk);
mutex_unlock(&clocks_mutex);
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
2022-11-25 9:26 [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable Anastasia Belova
@ 2022-11-25 14:14 ` Jonas Gorski
2022-11-25 17:43 ` Philippe Mathieu-Daudé
2022-11-27 20:29 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Jonas Gorski @ 2022-11-25 14:14 UTC (permalink / raw)
To: Anastasia Belova
Cc: Thomas Bogendoerfer, Jonathan Cameron, Randy Dunlap,
Florian Fainelli, Maxime Bizon, Ralf Baechle, linux-mips,
linux-kernel, lvc-project
On Fri, 25 Nov 2022 at 10:28, Anastasia Belova <abelova@astralinux.ru> wrote:
>
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
> arch/mips/bcm63xx/clk.c | 3 +++
> 1 file changed, 3 insertions(+)
Makes sense, especially since clk_disable() already has a NULL check
(in case anybody else wonders).
Reviewed-by: Jonas Gorski <jonas.gorski@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
2022-11-25 9:26 [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable Anastasia Belova
2022-11-25 14:14 ` Jonas Gorski
@ 2022-11-25 17:43 ` Philippe Mathieu-Daudé
2022-11-27 20:29 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-25 17:43 UTC (permalink / raw)
To: Anastasia Belova, Thomas Bogendoerfer
Cc: Jonathan Cameron, Randy Dunlap, Florian Fainelli, Maxime Bizon,
Ralf Baechle, linux-mips, linux-kernel, lvc-project
On 25/11/22 10:26, Anastasia Belova wrote:
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
> arch/mips/bcm63xx/clk.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
2022-11-25 9:26 [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable Anastasia Belova
2022-11-25 14:14 ` Jonas Gorski
2022-11-25 17:43 ` Philippe Mathieu-Daudé
@ 2022-11-27 20:29 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-11-27 20:29 UTC (permalink / raw)
To: Anastasia Belova, Thomas Bogendoerfer
Cc: Jonathan Cameron, Randy Dunlap, Maxime Bizon, Ralf Baechle,
linux-mips, linux-kernel, lvc-project
On 11/25/2022 1:26 AM, Anastasia Belova wrote:
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-27 20:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-25 9:26 [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable Anastasia Belova
2022-11-25 14:14 ` Jonas Gorski
2022-11-25 17:43 ` Philippe Mathieu-Daudé
2022-11-27 20:29 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).