From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, tsbogend@alpha.franken.de,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: spi: Add realtek,rtl9301-snand
Date: Tue, 15 Oct 2024 07:35:04 +0200 [thread overview]
Message-ID: <77b03a23-6880-4722-bafa-167bb5d45ae1@kernel.org> (raw)
In-Reply-To: <bd802a5c-e09e-4f4d-9d37-b87d85efb4e4@alliedtelesis.co.nz>
On 14/10/2024 22:38, Chris Packham wrote:
>
> On 14/10/24 20:12, Krzysztof Kozlowski wrote:
>> On Mon, Oct 14, 2024 at 02:52:43PM +1300, Chris Packham wrote:
>>
>>> diff --git a/Documentation/devicetree/bindings/spi/realtek,rtl9301-snand.yaml b/Documentation/devicetree/bindings/spi/realtek,rtl9301-snand.yaml
>>> new file mode 100644
>>> index 000000000000..397b32b41e86
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/spi/realtek,rtl9301-snand.yaml
>>> @@ -0,0 +1,59 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://scanmail.trustwave.com/?c=20988&d=3cSM59Be7zhiOY6j70BGhTh0kCvZ-1Nf0f5XJZnTzQ&u=http%3a%2f%2fdevicetree%2eorg%2fschemas%2fspi%2frealtek%2crtl9301-snand%2eyaml%23
>>> +$schema: http://scanmail.trustwave.com/?c=20988&d=3cSM59Be7zhiOY6j70BGhTh0kCvZ-1Nf0a1RIsqGnw&u=http%3a%2f%2fdevicetree%2eorg%2fmeta-schemas%2fcore%2eyaml%23
>>> +
>>> +title: SPI-NAND Flash Controller for Realtek RTL9300 SoCs
>>> +
>>> +maintainers:
>>> + - Chris Packham <chris.packham@alliedtelesis.co.nz>
>>> +
>>> +description:
>>> + The Realtek RTL9300 SoCs have a built in SPI-NAND controller. It supports
>>> + typical SPI-NAND page cache operations in single, dual or quad IO mode.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - realtek,rtl9301-snand
>>> + - realtek,rtl9302b-snand
>>> + - realtek,rtl9302c-snand
>>> + - realtek,rtl9303-snand
>> All of them look compatible with each other, why not using fallback to
>> 9301? That's common and expected pattern.
>
> So something like
>
> properties:
> compatible:
> oneOf:
> - items:
> - enum:
> - realtek,rtl9302b-snand
> - realtek,rtl9302c-snand
> - realtek,rtl9303-snand
> - const: realtek,rtl9301-snand
> - items:
Yes, except this one is not a list, so just const.
> const: realtek,rtl9301-snand
>
> Or am I over thinking it and I should just use only a single "const:
> realtek,rtl9301-snand"?
>
>>
>> Best regards,
>> Krzysztof
>>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-15 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 1:52 [PATCH v4 0/3] Realtek SPI-NAND controller Chris Packham
2024-10-14 1:52 ` [PATCH v4 1/3] dt-bindings: spi: Add realtek,rtl9301-snand Chris Packham
2024-10-14 7:12 ` Krzysztof Kozlowski
2024-10-14 20:38 ` Chris Packham
2024-10-15 5:35 ` Krzysztof Kozlowski [this message]
2024-10-14 1:52 ` [PATCH v4 2/3] mips: dts: realtek: Add SPI NAND controller Chris Packham
2024-10-14 1:52 ` [PATCH v4 3/3] spi: spi-mem: Add Realtek SPI-NAND controller Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b03a23-6880-4722-bafa-167bb5d45ae1@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).