From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45942C04E69 for ; Wed, 9 Aug 2023 04:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbjHIERR (ORCPT ); Wed, 9 Aug 2023 00:17:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjHIERQ (ORCPT ); Wed, 9 Aug 2023 00:17:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCC51BC3 for ; Tue, 8 Aug 2023 21:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691554589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jc2RrwZUDP/ZLfqGAQFdphKEXcWYocBgrdrh4msM7SQ=; b=K9eNG+CYTd5SuigFYgwGKVHV8Uwl061ui1TGhszVDnfmDlOqDK+BOII1662i4UA7LfakG8 C/sPoW6ud7PzyDhEcvwjKwrHBo+nc8/VbvnsDWuGmBCnPoDcrJ5urZJwEBB+eIiAkkQtjp HGa7tG5W+4dUoUbIdpd5OTDGR0f+nKI= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-xd0xbGgjNzm0_jMHmwBWhQ-1; Wed, 09 Aug 2023 00:16:27 -0400 X-MC-Unique: xd0xbGgjNzm0_jMHmwBWhQ-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-5635233876bso4530347a12.0 for ; Tue, 08 Aug 2023 21:16:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691554283; x=1692159083; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jc2RrwZUDP/ZLfqGAQFdphKEXcWYocBgrdrh4msM7SQ=; b=JaYWn4XfzBl10iLxi3bLD6Gl8jNGM+9fsssdBj52iiAH8oV591tkJ6+PYiC0yz3Rec KC96xvmItS5BOtoKmWJ/0IsRBNongubd8gXv11L8DPaSk2DXS0QAl4DukKIC9IxL0O+7 78P414gOeg9jgP2fdhRRAFUsJssCWpXSXeOZqSBRV3rYst75iQuNGve/dD/5EZ0IoJxU 22qthxSA1ZP7l+dvwLHnreEpzV99i/A65eyJ2CysZluUfNEoJ1kbl9wtcZuteiEW3k7p 2JpUjIEiq7GcQDS5z/ivvIqYnz4EJ3BG+XuX3xEnDQUnP2WxNFb1RCAjprkFXep5jM2L EBZg== X-Gm-Message-State: AOJu0YylBMWu9epGXDZcJWabk5P8L1Ro1xn0Z03Nz6hzHghZk+QeYkSz 4ulTlcC9qw3FhGvgrO8Djo60tsoR5l71sOF5GsVv85mmpM2sk4hrTtDvNXW3emPVfD7ZQdzhXdE u3UqUMA2BGAbtvBJ+EdGzuA== X-Received: by 2002:a05:6a21:328b:b0:121:ca90:df01 with SMTP id yt11-20020a056a21328b00b00121ca90df01mr1394017pzb.40.1691554282922; Tue, 08 Aug 2023 21:11:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuTcKraAGNvme4rsh9nauIBvvaQvIf9BEXJr92oZnpUAljzMU4HrA4zieEd0juLoJJfRohRg== X-Received: by 2002:a05:6a21:328b:b0:121:ca90:df01 with SMTP id yt11-20020a056a21328b00b00121ca90df01mr1394005pzb.40.1691554282647; Tue, 08 Aug 2023 21:11:22 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id y9-20020a17090322c900b001b2069072ccsm9850474plg.18.2023.08.08.21.11.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 21:11:22 -0700 (PDT) Message-ID: <79b8548e-715a-85ee-aad6-cb0b97753df6@redhat.com> Date: Wed, 9 Aug 2023 14:11:09 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v8 04/14] KVM: Remove CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL Content-Language: en-US To: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose Cc: Paolo Bonzini , Sean Christopherson , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Shaoqin Huang References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-5-rananta@google.com> From: Gavin Shan In-Reply-To: <20230808231330.3855936-5-rananta@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 8/9/23 09:13, Raghavendra Rao Ananta wrote: > kvm_arch_flush_remote_tlbs() or CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL > are two mechanisms to solve the same problem, allowing > architecture-specific code to provide a non-IPI implementation of > remote TLB flushing. > > Dropping CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL allows KVM to standardize > all architectures on kvm_arch_flush_remote_tlbs() instead of > maintaining two mechanisms. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Shaoqin Huang > --- > virt/kvm/Kconfig | 3 --- > virt/kvm/kvm_main.c | 2 -- > 2 files changed, 5 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index b74916de5183a..484d0873061ca 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -62,9 +62,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT > config KVM_VFIO > bool > > -config HAVE_KVM_ARCH_TLB_FLUSH_ALL > - bool > - > config HAVE_KVM_INVALID_WAKEUPS > bool > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 70e5479797ac3..d6b0507861550 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -345,7 +345,6 @@ bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req) > } > EXPORT_SYMBOL_GPL(kvm_make_all_cpus_request); > > -#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL > void kvm_flush_remote_tlbs(struct kvm *kvm) > { > ++kvm->stat.generic.remote_tlb_flush_requests; > @@ -366,7 +365,6 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) > ++kvm->stat.generic.remote_tlb_flush; > } > EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs); > -#endif > > static void kvm_flush_shadow_all(struct kvm *kvm) > {