* question on mips/kernel/setup.c
@ 2022-02-20 23:56 Randy Dunlap
2022-02-21 6:06 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-02-20 23:56 UTC (permalink / raw)
To: Thomas Bogendoerfer, open list:BROADCOM NVRAM DRIVER,
Christoph Hellwig
from commit 14ac09a65e19
Author: Christoph Hellwig <hch@lst.de>
Date: Wed Feb 10 10:56:38 2021 +0100
MIPS: refactor the runtime coherent vs noncoherent DMA indicators
Both of these command line options set 'dma_default_coherent' to true.
Is that correct or a typo? Or it doesn't matter?
Thanks.
arch/mips/kernel/setup.c:
static int __init setcoherentio(char *str)
{
dma_default_coherent = true;
pr_info("Hardware DMA cache coherency (command line)\n");
return 0;
}
early_param("coherentio", setcoherentio);
static int __init setnocoherentio(char *str)
{
dma_default_coherent = true;
pr_info("Software DMA cache coherency (command line)\n");
return 0;
}
early_param("nocoherentio", setnocoherentio);
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: question on mips/kernel/setup.c
2022-02-20 23:56 question on mips/kernel/setup.c Randy Dunlap
@ 2022-02-21 6:06 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-02-21 6:06 UTC (permalink / raw)
To: Randy Dunlap
Cc: Thomas Bogendoerfer, open list:BROADCOM NVRAM DRIVER,
Christoph Hellwig
On Sun, Feb 20, 2022 at 03:56:42PM -0800, Randy Dunlap wrote:
> Both of these command line options set 'dma_default_coherent' to true.
>
> Is that correct or a typo? Or it doesn't matter?
It is a typo, but apparently no one noticed in all the time.
nocoherentio should set it to false.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-21 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-20 23:56 question on mips/kernel/setup.c Randy Dunlap
2022-02-21 6:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).