From: Kevin Hilman <khilman@baylibre.com>
To: Paul Burton <paul.burton@mips.com>,
"linux-mips\@vger.kernel.org" <linux-mips@vger.kernel.org>
Cc: Paul Burton <pburton@wavecomp.com>,
Guenter Roeck <linux@roeck-us.net>,
"Maciej W . Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper
Date: Tue, 29 Jan 2019 09:48:40 +0100 [thread overview]
Message-ID: <7h8sz3rgrb.fsf@baylibre.com> (raw)
In-Reply-To: <20190128222106.19100-1-paul.burton@mips.com>
Paul Burton <paul.burton@mips.com> writes:
> The MIPS VDSO build currently doesn't provide the -msoft-float flag to
> the compiler as the kernel proper does. This results in an attempt to
> use the compiler's default floating point configuration, which can be
> problematic in cases where this is incompatible with the target CPU's
> -march= flag. For example decstation_defconfig fails to build using
> toolchains in which gcc was configured --with-fp-32=xx with the
> following error:
>
> LDS arch/mips/vdso/vdso.lds
> cc1: error: '-march=r3000' requires '-mfp32'
> make[2]: *** [scripts/Makefile.build:379: arch/mips/vdso/vdso.lds] Error 1
>
> The kernel proper avoids this error because we build with the
> -msoft-float compiler flag, rather than using the compiler's default.
> Pass this flag through to the VDSO build so that it too becomes agnostic
> to the toolchain's floating point configuration.
>
> Note that this is filtered out from KBUILD_CFLAGS rather than simply
> always using -msoft-float such that if we switch the kernel to use
> -mno-float in the future the VDSO will automatically inherit the change.
>
> The VDSO doesn't actually include any floating point code, and its
> .MIPS.abiflags section is already manually generated to specify that
> it's compatible with any floating point ABI. As such this change should
> have no effect on the resulting VDSO, apart from fixing the build
> failure for affected toolchains.
>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Maciej W. Rozycki <macro@linux-mips.org>
> References: https://lore.kernel.org/linux-mips/1477843551-21813-1-git-send-email-linux@roeck-us.nets/
> References: https://kernelci.org/build/id/5c4e4ae059b5142a249ad004/logs/
Tested-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2019-01-29 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 22:21 [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper Paul Burton
2019-01-28 23:16 ` [PATCH] MIPS: VDSO: Include $(ccflags-vdso) in o32,n32 .lds builds Paul Burton
2019-01-29 19:51 ` Paul Burton
2019-01-29 8:48 ` Kevin Hilman [this message]
2019-01-29 19:51 ` [PATCH] MIPS: VDSO: Use same -m%-float cflag as the kernel proper Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8sz3rgrb.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-mips@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=macro@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).