Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: disable MMID if GINVT is not usable
Date: Wed, 25 Jun 2025 15:44:00 +0100	[thread overview]
Message-ID: <808e21d2-1212-4358-9ba6-29f9d097be8a@app.fastmail.com> (raw)
In-Reply-To: <20250625-mmid_disable_no_ginv_on_noc-v1-1-38a3902607a7@bootlin.com>

在2025年6月25日周三 下午2:27,Gregory CLEMENT写道:

Hi Gregory,

> If System-level Interconnect (aka Network on Chip) does not support
> the global invalidation, then MMID feature is not usable. Indeed the
> current implementation of MMID relies on the GINV* instruction.

Yes, it is the case if the NoC IP can't handle AMBA ACE DVM requests.

>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
>  arch/mips/Kconfig                    | 6 ++++++
>  arch/mips/include/asm/cpu-features.h | 5 ++++-
>  arch/mips/mobileye/Kconfig           | 2 ++
>  3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 
> 1e48184ecf1ec8e29c0a25de6452ece5da835e30..05ce008459b89f03fa71d94429607feb9d06526f 
> 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2575,6 +2575,12 @@ config WAR_R10000_LLSC
>  config WAR_MIPS34K_MISSED_ITLB
>  	bool
> 
> +# Some I6500 based SoC do not support the global invalidation on their
> +# System-level Interconnect (aka Network on Chip), this have an
> +# influence on the MMID support.
> +config GINVT_UNSUPPORTED_NOC
> +	bool
> +

I believe this should be a DeviceTree property of CM node instead of Kconfig
hack.

Thanks

-- 
- Jiaxun

  reply	other threads:[~2025-06-25 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 13:27 [PATCH] MIPS: disable MMID if GINVT is not usable Gregory CLEMENT
2025-06-25 14:44 ` Jiaxun Yang [this message]
2025-07-02 12:08   ` Thomas Bogendoerfer
2025-07-04 15:17     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=808e21d2-1212-4358-9ba6-29f9d097be8a@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox