From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Huacai Chen" <chenhuacai@kernel.org>
Cc: "Kelvin Cheung" <keguang.zhang@gmail.com>,
"Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Conor Dooley" <conor.dooley@microchip.com>
Subject: Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA
Date: Wed, 17 Jul 2024 22:20:01 +0800 [thread overview]
Message-ID: <84d2591b-4336-453f-bcb2-a7c47df0574c@app.fastmail.com> (raw)
In-Reply-To: <CAAhV-H6aaAu=0eyEp8am8A+SSj53+CGp7DrCYCxkNZScBd74BQ@mail.gmail.com>
在2024年7月17日七月 下午9:06,Huacai Chen写道:
> On Tue, Jul 16, 2024 at 9:12 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>
>>
>>
>> 在2024年7月16日七月 下午5:40,Huacai Chen写道:
>> > On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>> >>
>> >>
>> >>
>> >> 在2024年7月15日七月 下午2:39,Huacai Chen写道:
>> >> [...]
>> >> >
>> >> >> You said that you've accepted my suggestion, which means you recognize
>> >> >> 'loongson' as the better name for the drivers.
>> >> > No, I don't think so, this is just a compromise to keep consistency.
>> >>
>> >> Folks, can we settle on this topic?
>> >>
>> >> Is this naming really important? As long as people can read actual chip name from
>> >> kernel code & documents, I think both are acceptable.
>> >>
>> >> I suggest let this patch go as is. And if anyone want to unify the naming, they can
>> >> propose a treewide patch.
>> > Renaming still breaks config files.
>>
>> This is trival with treewide sed :-)
> Please read the commit message of b8d3349803ba34afda429e87a837fd95a carefully.
We don't have 114 defconfigs don't we?
Those symbols are not frequently specified by down stream users either.
I think Keguang had tried his best on resolving all reasonable comments.
Naming is a matter of preference after all, I think we should give Keguang some respect
here.
Thanks
- Jiaxun
>
> Huacai
>
>>
>> Thanks
>> - Jiaxun
>>
>> --
>> - Jiaxun
--
- Jiaxun
prev parent reply other threads:[~2024-07-17 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 10:55 [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA Keguang Zhang via B4 Relay
2024-07-11 10:55 ` [PATCH RESEND v9 1/2] dt-bindings: dma: Add Loongson-1 " Keguang Zhang via B4 Relay
2024-07-11 10:55 ` [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver Keguang Zhang via B4 Relay
2024-07-13 21:11 ` kernel test robot
2024-07-25 5:57 ` Vinod Koul
2024-07-25 10:07 ` Keguang Zhang
2024-07-13 23:24 ` kernel test robot
2024-07-12 4:22 ` [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA Huacai Chen
2024-07-12 6:23 ` Keguang Zhang
2024-07-15 6:39 ` Huacai Chen
2024-07-15 6:55 ` Keguang Zhang
2024-07-15 7:00 ` Jiaxun Yang
2024-07-16 9:40 ` Huacai Chen
2024-07-16 13:10 ` Jiaxun Yang
2024-07-17 13:06 ` Huacai Chen
2024-07-17 14:20 ` Jiaxun Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d2591b-4336-453f-bcb2-a7c47df0574c@app.fastmail.com \
--to=jiaxun.yang@flygoat.com \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).