From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
John Crispin <john@phrozen.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
erkin.bozoglu@xeront.com
Subject: Re: [PATCH 2/2] mips: ralink: make SOC_MT7621 select PINCTRL
Date: Tue, 21 Feb 2023 13:09:10 +0300 [thread overview]
Message-ID: <85a39e81-51a3-e90f-622e-f2cc7528aa92@arinc9.com> (raw)
In-Reply-To: <CAMhs-H9qLw6uhjPnFWovQBMFe38y95Q_VvG8Bj9wovSR+1J_2g@mail.gmail.com>
On 21.02.2023 12:38, Sergio Paracuellos wrote:
> Hi Arınç,
>
> On Tue, Feb 21, 2023 at 10:24 AM <arinc9.unal@gmail.com> wrote:
>>
>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>>
>> Currently, out of every Ralink SoC, only the dt-binding of the MT7621 SoC
>> uses pinctrl. Because of this, PINCTRL is not selected at all. Make
>> SOC_MT7621 select PINCTRL.
>>
>> Remove PINCTRL_MT7621, enabling it for the MT7621 SoC will be handled under
>> the PINCTRL_MT7621 option.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>> arch/mips/ralink/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
>> index 06031796c87b..83e61e147b90 100644
>> --- a/arch/mips/ralink/Kconfig
>> +++ b/arch/mips/ralink/Kconfig
>> @@ -54,7 +54,7 @@ choice
>> select HAVE_PCI
>> select PCI_DRIVERS_GENERIC
>> select SOC_BUS
>> - select PINCTRL_MT7621
>> + select PINCTRL
>>
>> help
>> The MT7621 system-on-a-chip includes an 880 MHz MIPS1004Kc
>> --
>> 2.37.2
>>
>
> Which git tree are you working against? CONFIG_SOC_MT7621 is not
> selecting PINCTRL_MT7621 at all in v6.2 [0]. I think it should select
mips/linux.git mips-next tree.
https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/log/
> 'PINCTRL_MT7621' and the 'select PINCTRL' stuff added inside the
> PINCTRL_RALINK option in [1].
I'm working on that, although not exactly the way you describe here, on
this branch of mine.
https://github.com/arinc9/linux/commits/ralink-pinctrl
Arınç
next prev parent reply other threads:[~2023-02-21 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:24 [PATCH 1/2] mips: remove SYS_HAS_CPU_MIPS32_R1 from RALINK arinc9.unal
2023-02-21 9:24 ` [PATCH 2/2] mips: ralink: make SOC_MT7621 select PINCTRL arinc9.unal
2023-02-21 9:38 ` Sergio Paracuellos
2023-02-21 10:09 ` Arınç ÜNAL [this message]
2023-02-21 10:21 ` Sergio Paracuellos
2023-02-21 10:54 ` Arınç ÜNAL
2023-02-21 15:33 ` Sergio Paracuellos
2023-02-27 22:55 ` Thomas Bogendoerfer
2023-02-21 15:34 ` [PATCH 1/2] mips: remove SYS_HAS_CPU_MIPS32_R1 from RALINK Sergio Paracuellos
2023-02-27 22:55 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a39e81-51a3-e90f-622e-f2cc7528aa92@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=erkin.bozoglu@xeront.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).