From: Juan Quintela <quintela@mandrakesoft.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] SGI Seeq cleanup
Date: Thu, 08 May 2003 00:14:56 +0200 [thread overview]
Message-ID: <86d6iul7z3.fsf@trasno.mitica> (raw)
In-Reply-To: <20030507202851.GA668@kopretinka> (Ladislav Michl's message of "Wed, 7 May 2003 22:28:51 +0200")
>>>>> "ladis" == Ladislav Michl <ladis@linux-mips.org> writes:
ladis> read eaddr using NVRAM access fuctions and make various cleanups so driver
ladis> can be build as module
You are my hero!
[ Removal of Space.c entry ]
Hero++
ladis> @@ -96,8 +97,8 @@
ladis> struct sgiseeq_private {
ladis> volatile struct sgiseeq_init_block srings;
ladis> char *name;
ladis> - volatile struct hpc3_ethregs *hregs;
ladis> - volatile struct sgiseeq_regs *sregs;
ladis> + struct hpc3_ethregs *hregs;
ladis> + struct sgiseeq_regs *sregs;
I read through all the patch, and I didn't understand why volatile is
not needed anymore :(
Althought not that I did understand why it was needed in the first
place :)
ladis> @@ -435,7 +439,7 @@
ladis> /* Always check for received packets. */
ladis> sgiseeq_rx(dev, sp, hregs, sregs);
ladis> - /* Only check for tx acks iff we have something queued. */
ladis> + /* Only check for tx acks if we have something queued. */
ladis> if (sp->tx_old != sp->tx_new)
ladis> sgiseeq_tx(dev, sp, hregs, sregs);
iff == Math speak for if and only if. Not sure if iff is needed in
that context at all.
Later, Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next prev parent reply other threads:[~2003-05-07 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 20:28 [PATCH] SGI Seeq cleanup Ladislav Michl
2003-05-07 22:14 ` Juan Quintela [this message]
2003-05-08 7:43 ` Ladislav Michl
2003-05-08 12:20 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d6iul7z3.fsf@trasno.mitica \
--to=quintela@mandrakesoft.com \
--cc=ladis@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox