From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E860EEB595 for ; Sat, 9 Sep 2023 16:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbjIIQZZ (ORCPT ); Sat, 9 Sep 2023 12:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232860AbjIIOiR (ORCPT ); Sat, 9 Sep 2023 10:38:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E01B195 for ; Sat, 9 Sep 2023 07:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694270252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eRcOkbLQiqXFau3Lzv+lkDuNMwp9k8LF7/IY5MKHdsU=; b=Ekf6PoiE+uQ9x88AYf4zRfx2CZ4HUSwTWAy6jueKhvlxWQvPU07NpxTYR4Pifoul6PvRCp GiAFHD4SxPQED2r3f2VACAFcB+86bf3p46XrLo6aSLKhRQyERax0G3I/JqIza5n1VqfHUR xKf8tK6fwiquMNSCboljOwNHaPXhXls= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-hb3OsNddOTagtpPnyABW8g-1; Sat, 09 Sep 2023 10:37:31 -0400 X-MC-Unique: hb3OsNddOTagtpPnyABW8g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbdf341934so23534885e9.3 for ; Sat, 09 Sep 2023 07:37:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694270250; x=1694875050; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eRcOkbLQiqXFau3Lzv+lkDuNMwp9k8LF7/IY5MKHdsU=; b=UxeUulLH2tgrGa1cqp07eaYPX7qCZ+/1BjOPzgxtOi4k4qIEuj4+qtlcddUAqo4sjv OpYV+jga+uGtK0jSJhC6UAf9Dv5oOVNUFfw6Gnb8tWGHT6Lf0tcxhvTnVblO3gk1Q/PJ sXnYKjoqKndYK44qgBPr93OBeqUyWhegKX04J2d/vEbi1vdcUXAk1q1TxqY3d0qI1qih rJNjoZG0+x3WKYY6oSrejbg4ZaCB6PeyiSx4zrVdSolQnmLU0LBMeDKptjZdXWkl+FeB FQTsOvbxoDMpGRF3Vq61F/AyeOwu97CwfxVk0QDKJ4LHypLFua/NDusvYUPpnCfFUTPX v10g== X-Gm-Message-State: AOJu0YxTOjFrBNuOuFCnrq0dByiAi4Mp9j5EwsKk0qAuJw5VD5h2bk7G Dw6bNclLWQHG4FuNGIUOzBzBimAK4D4HvNQgI3Yz3ruPzUCwxk13RZIjP7CJiZFVDBa3U/hdK37 pM7RSj7fKP+vYfGXmeKPWXQ== X-Received: by 2002:a05:600c:2483:b0:401:d2cb:e6f3 with SMTP id 3-20020a05600c248300b00401d2cbe6f3mr5088935wms.1.1694270250170; Sat, 09 Sep 2023 07:37:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuI0CHTrTRuHu7U+ySuZ17CrBG1YsmWNBf7nwWhsv6ytgzHpvaJlIL3zjF99nLHiP4wc2jkQ== X-Received: by 2002:a05:600c:2483:b0:401:d2cb:e6f3 with SMTP id 3-20020a05600c248300b00401d2cbe6f3mr5088899wms.1.1694270249806; Sat, 09 Sep 2023 07:37:29 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id k20-20020a7bc414000000b003fd2e898aa3sm3071184wmi.0.2023.09.09.07.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 07:37:28 -0700 (PDT) From: Javier Martinez Canillas To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Mali DP Maintainers , dri-devel@lists.freedesktop.org, kernel@pengutronix.de, Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Jonas Karlman , Fabio Estevam , NXP Linux Team , Russell King , Christian Gmeiner , etnaviv@lists.freedesktop.org, Alim Akhtar , linux-samsung-soc@vger.kernel.org, Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , linux-mips@vger.kernel.org, lima@lists.freedesktop.org, AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org, Sean Paul , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, Steven Price , Alyssa Rosenzweig , linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void In-Reply-To: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> References: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de> Date: Sat, 09 Sep 2023 16:37:28 +0200 Message-ID: <8734znjtuf.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Uwe Kleine-K=C3=B6nig writes: Hello Uwe, > Hello, > > this patch series adapts the platform drivers below drivers/gpu/drm > to use the .remove_new() callback. Compared to the traditional .remove() > callback .remove_new() returns no value. This is a good thing because > the driver core doesn't (and cannot) cope for errors during remove. The > only effect of a non-zero return value in .remove() is that the driver > core emits a warning. The device is removed anyhow and an early return > from .remove() usually yields a resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably (but wrongly) assume any more that there happens some kind of > cleanup later. > > Best regards > Uwe > > Uwe Kleine-K=C3=B6nig (53): [...] > drm/imx/ipuv3: Convert to platform remove callback returning void > drm/ingenic: Convert to platform remove callback returning void [...] > drm/mediatek: Convert to platform remove callback returning void > drm/mediatek: Convert to platform remove callback returning void [...] > drm/msm: Convert to platform remove callback returning void [...] > drm/shmobile: Convert to platform remove callback returning void Pushed these to drm-misc (drm-misc-next). Thanks! --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat