From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 02 Mar 2017 12:18:45 +0100 (CET) Received: from ozlabs.org ([103.22.144.67]:57361 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992213AbdCBLSiT0ApE (ORCPT ); Thu, 2 Mar 2017 12:18:38 +0100 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 3vYqYz54HVz9s7j; Thu, 2 Mar 2017 22:18:31 +1100 (AEDT) From: Michael Ellerman To: David Daney , Jason Baron , Steven Rostedt , Sachin Sant , linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Chris Metcalf , Ralf Baechle , Russell King , Rabin Vincent , Paul Mackerras , Anton Blanchard , Ingo Molnar , Zhigang Lu , David Daney Subject: Re: [PATCH] module: set __jump_table alignment to 8 In-Reply-To: <87varsj6qc.fsf@concordia.ellerman.id.au> References: <20170301220453.4756-1-david.daney@cavium.com> <87varsj6qc.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 02 Mar 2017 22:18:30 +1100 Message-ID: <8737ewexkp.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 56995 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mpe@ellerman.id.au Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Michael Ellerman writes: > David Daney writes: >> Strict alignment became necessary with commit 3821fd35b58d >> ("jump_label: Reduce the size of struct static_key"), currently in >> linux-next, which uses the two least significant bits of pointers to >> __jump_table elements. > > It would obviously be nice if this could go in before the commit that > exposes the breakage, but I guess that's problematic because Steve > doesn't want to rebase the tracing tree. > > Steve I think you've already sent your pull request for this cycle? So I > guess if this can go in your first batch of fixes? Ugh. Was looking at the wrong tree - Linus has already merged the commit in question, so the above is all moot. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ozlabs.org ([103.22.144.67]:57361 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992213AbdCBLSiT0ApE (ORCPT ); Thu, 2 Mar 2017 12:18:38 +0100 From: Michael Ellerman Subject: Re: [PATCH] module: set __jump_table alignment to 8 In-Reply-To: <87varsj6qc.fsf@concordia.ellerman.id.au> References: <20170301220453.4756-1-david.daney@cavium.com> <87varsj6qc.fsf@concordia.ellerman.id.au> Date: Thu, 02 Mar 2017 22:18:30 +1100 Message-ID: <8737ewexkp.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney , Jason Baron , Steven Rostedt , Sachin Sant , linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Chris Metcalf , Ralf Baechle , Russell King , Rabin Vincent , Paul Mackerras , Anton Blanchard , Ingo Molnar , Zhigang Lu Message-ID: <20170302111830.dIDtbrDXDcoX4KJ9A7uFxAhv7Xsvem7lo2ubzoXaHYI@z> Michael Ellerman writes: > David Daney writes: >> Strict alignment became necessary with commit 3821fd35b58d >> ("jump_label: Reduce the size of struct static_key"), currently in >> linux-next, which uses the two least significant bits of pointers to >> __jump_table elements. > > It would obviously be nice if this could go in before the commit that > exposes the breakage, but I guess that's problematic because Steve > doesn't want to rebase the tracing tree. > > Steve I think you've already sent your pull request for this cycle? So I > guess if this can go in your first batch of fixes? Ugh. Was looking at the wrong tree - Linus has already merged the commit in question, so the above is all moot. cheers