* [PATCH] vgacon: fix mips/sibyte build regression
@ 2023-10-24 5:44 Arnd Bergmann
2023-10-24 7:28 ` Javier Martinez Canillas
2023-10-25 12:56 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-10-24 5:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, kernel test robot, Thomas Bogendoerfer,
Javier Martinez Canillas, Helge Deller, Khalid Aziz, linux-mips,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The conversion to vgacon_register_screen() was missing an #include statement
for the swarm board:
arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@intel.com/
Fixes: 555624c0d10b vgacon: clean up global screen_info instances
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/mips/sibyte/swarm/setup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/sibyte/swarm/setup.c b/arch/mips/sibyte/swarm/setup.c
index 74e7c242b690..38c90b5e8754 100644
--- a/arch/mips/sibyte/swarm/setup.c
+++ b/arch/mips/sibyte/swarm/setup.c
@@ -13,6 +13,7 @@
#include <linux/memblock.h>
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/console.h>
#include <linux/screen_info.h>
#include <linux/initrd.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vgacon: fix mips/sibyte build regression
2023-10-24 5:44 [PATCH] vgacon: fix mips/sibyte build regression Arnd Bergmann
@ 2023-10-24 7:28 ` Javier Martinez Canillas
2023-10-25 12:56 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2023-10-24 7:28 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: Arnd Bergmann, kernel test robot, Thomas Bogendoerfer,
Helge Deller, Khalid Aziz, linux-mips, linux-kernel
Arnd Bergmann <arnd@kernel.org> writes:
Hello Arnd,
> From: Arnd Bergmann <arnd@arndb.de>
>
> The conversion to vgacon_register_screen() was missing an #include statement
> for the swarm board:
>
> arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@intel.com/
> Fixes: 555624c0d10b vgacon: clean up global screen_info instances
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Loos good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vgacon: fix mips/sibyte build regression
2023-10-24 5:44 [PATCH] vgacon: fix mips/sibyte build regression Arnd Bergmann
2023-10-24 7:28 ` Javier Martinez Canillas
@ 2023-10-25 12:56 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-25 12:56 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: Arnd Bergmann, kernel test robot, Thomas Bogendoerfer,
Javier Martinez Canillas, Helge Deller, Khalid Aziz, linux-mips,
linux-kernel
On 24/10/23 07:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The conversion to vgacon_register_screen() was missing an #include statement
> for the swarm board:
>
> arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@intel.com/
> Fixes: 555624c0d10b vgacon: clean up global screen_info instances
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/mips/sibyte/swarm/setup.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-25 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 5:44 [PATCH] vgacon: fix mips/sibyte build regression Arnd Bergmann
2023-10-24 7:28 ` Javier Martinez Canillas
2023-10-25 12:56 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).