From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793634946; b=1NM1upXTpMemvz4BXiz23oUR7OhhUzEZ8fK60elU592NBi9r3U989lkChoCkQ6eZGuqq CDibvjyMs6PoBoU/Ok+kUG4CqbcFCTY7GU0Wyzlms0rZ4UCY+nReMnNtn8vrqfFronPvS Vxx5BZV59PnIOU7LAzKyDcz/DdKJs93oWPybJLwa7dgRr53hpnKSNKMNil5ZKSwjONeLF myUIMzkRhmNZSwGlaNzb7LGmYsjAUqEPho8joU/ZNfqc06O7EXd1cO4Tb9JHWn7OPzWjg XpCdjN6ROIfddwPrSm1/9aQApcI9s1ylHxfx2+5IgGkl/7L6gJR7nUCWC/3muL0c3xA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793634946; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=ZsBtyqiFaBBCC9dG9FA7W+94CvmMBULM/6mxGT3R8BM=; b=dMYnFH6q+szl8t6Uz/a7t5MQ0D6naWu7Yf78sWXNfoNHvZ87L9731D5D1cSmr6noG8yU fJXksVFQFlaDpJEgyZY505d+whH5Kqpu3r3nQnrf3UlqmDX6oXAFVNYUGiiN79xDS6iF1 pvh6+9bf2fZA6SvTrCFRKh4WlMHZ/RN8ORz/koUJTCfinfBJOc7LPeppAyXDWUKKmS5ng 8eN85zSVT1k56/lWHb9rueLCDCEzq6PjC772NJOLPfLc8unjdGtVV0wQ3/n15yehMdJqs A4HXhtPEmJP28usOD1/qfSqxYfxL01fQbWgTh6IMuBOEdE0zBxaLJ2OVP/9qwTNKyRA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=CwvcFy+J; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC15606A58B; Mon, 2 Nov 2026 15:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1CC15606A58B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=CwvcFy+J Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 6F57B4E413D5; Mon, 2 Nov 2026 15:55:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3C14260750; Mon, 2 Nov 2026 15:55:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4B71410328E6F; Mon, 2 Nov 2026 16:55:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1793634941; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ZsBtyqiFaBBCC9dG9FA7W+94CvmMBULM/6mxGT3R8BM=; b=CwvcFy+J9S0wTdIsKcWAkHYs5ZvouQoUrRmVIw1RULGNtbrutD3neWuBZifCfDT1xy6W36 KDh9++9M23/rYWeQgh+LmfGEjGfEj3AKBDLwlVE7y8Ga51EEvS3ajrWe45BHPnn4YMLB8G QpsBlCT3ePQ3va1B/b7XA1cOcv5H/pAUKFsi5dnzwgsP7cnJLg9HBnS9uI4fiscXatSO4r 6DEV9Z56hvyapq+QBaxXnrfIhKTnjWENclShIZEUxdh98I0ogvd2ofdAvlMlgU+OMOz510 81xq2b8OVpflPQ0QDlgn2gevr+35Cjn1xnBIE3HvP4d/LQoVqM+HpRQeFRBOtw== From: Gregory CLEMENT To: Krzysztof Kozlowski Cc: Vladimir Kondratiev , =?utf-8?Q?Beno?= =?utf-8?Q?=C3=AEt?= Monin , =?utf-8?Q?Th=C3=A9o?= Lebrun , Thomas Gleixner , Radu Rendec , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Thomas Petazzoni , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: interrupt-controller: add Mobileye EyeQ5 PCIe MSI controller In-Reply-To: <20261029-positive-unbreakable-zebu-d4484c@quoll> References: <20261028-eyeq5_msi-v1-0-c464752fb55f@bootlin.com> <20261028-eyeq5_msi-v1-1-c464752fb55f@bootlin.com> <20261029-positive-unbreakable-zebu-d4484c@quoll> Date: Mon, 02 Nov 2026 16:55:37 +0100 Message-ID: <878q3b2pom.fsf@BLaptop.bootlin.com> X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Krzysztof Kozlowski writes: >> + num-vectors: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Number of MSI vectors that the port supports. >> + minimum: 1 >> + maximum: 4 > > So your SoC has multiple blocks with different number of vectors? No it has always the same number of vector, so you are right I will remove it. > >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-controller >> + - '#interrupt-cells' >> + - msi-controller >> + - '#msi-cells' >> + - memory-region >> + - num-vectors >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + > > From here... > >> + / { >> + #address-cells =3D <2>; >> + #size-cells =3D <2>; >> + >> + gic: interrupt-controller { >> + compatible =3D "mti,cpu-interrupt-controller"; >> + interrupt-controller; >> + #interrupt-cells =3D <3>; >> + }; >> + >> + reserved-memory { >> + #address-cells =3D <2>; >> + #size-cells =3D <2>; >> + ranges; >> + >> + pci0_msi_reserved: pci0-msi@806000000 { >> + reg =3D <0x8 0x06000000 0x0 0x100000>; >> + }; >> + }; >> + > > .. to here drop everything. This causes warnings. > >> + soc { >> + #address-cells =3D <2>; >> + #size-cells =3D <2>; >> + ranges; >> + >> + msi0: msi-controller@5840000 { > > Drop unused DT label. OK I was too close to my DT for no real reason. I will simplify the example. Thanks, Gregory > >> + compatible =3D "mobileye,eyeq5-msi"; >> + reg =3D <0x0 0x05840000 0x0 0x10>, >> + <0x0 0x05840040 0x0 0x20>; >> + label =3D "port0-msi"; >> + interrupt-parent =3D <&gic>; >> + interrupts =3D ; >> + interrupt-controller; >> + #interrupt-cells =3D <1>; >> + msi-controller; >> + #msi-cells =3D <0>; >> + memory-region =3D <&pci0_msi_reserved>; >> + num-vectors =3D <4>; >> + }; >> + }; >> + }; >>=20 >> --=20 >> 2.53.0 >>=20 --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com