Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Julien BLACHE <jblache@debian.org>
To: debian-mips@lists.debian.org
Cc: linux-mips@linux-mips.org
Subject: Re: IP22 RTC bug on 64bit 2.6 kernels ?
Date: Sun, 09 Jul 2006 00:21:24 +0200	[thread overview]
Message-ID: <87ac7jhh5n.fsf@frigate.technologeek.org> (raw)
In-Reply-To: <87fyhbhi1n.fsf@frigate.technologeek.org> (Julien BLACHE's message of "Sun, 09 Jul 2006 00:02:12 +0200")

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Julien BLACHE <jblache@debian.org> wrote:

Hi,

> So, it looks like there is a bug in this area with (at least) 64bit
> 2.6 kernels. Is there any known bug ? Anything I can do to help track
> the problem down ?

Ok, it's brown paper bag time for someone :-)


This patch fixes a typo in arch/mips/sgi-ip22/ip22-time.c, leading to
the incorrect year being set into the RTC chip.

Signed-off-by: Julien BLACHE <jb@jblache.org>


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Typo fix in arch/mips/sgi-ip22/ip22-time.c --]
[-- Type: text/x-patch, Size: 524 bytes --]

--- arch/mips/sgi-ip22/ip22-time.c.orig	2006-07-08 22:17:02.000000000 +0000
+++ arch/mips/sgi-ip22/ip22-time.c	2006-07-08 22:17:29.000000000 +0000
@@ -76,7 +76,7 @@
 	save_control = hpc3c0->rtcregs[RTC_CMD] & 0xff;
 	hpc3c0->rtcregs[RTC_CMD] = save_control | RTC_TE;
 
-	hpc3c0->rtcregs[RTC_YEAR] = BIN2BCD(tm.tm_sec);
+	hpc3c0->rtcregs[RTC_YEAR] = BIN2BCD(tm.tm_year);
 	hpc3c0->rtcregs[RTC_MONTH] = BIN2BCD(tm.tm_mon);
 	hpc3c0->rtcregs[RTC_DATE] = BIN2BCD(tm.tm_mday);
 	hpc3c0->rtcregs[RTC_HOURS] = BIN2BCD(tm.tm_hour);

[-- Attachment #3: Type: text/plain, Size: 232 bytes --]



Thanks,

JB.

-- 
 Julien BLACHE - Debian & GNU/Linux Developer - <jblache@debian.org> 
 
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 

      reply	other threads:[~2006-07-08 22:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-08 22:02 IP22 RTC bug on 64bit 2.6 kernels ? Julien BLACHE
2006-07-08 22:21 ` Julien BLACHE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ac7jhh5n.fsf@frigate.technologeek.org \
    --to=jblache@debian.org \
    --cc=debian-mips@lists.debian.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox