From: Kalle Valo <kvalo@codeaurora.org>
To: James Hogan <jhogan@kernel.org>
Cc: Sven Joachim <svenjoac@gmx.de>, Michael Buesch <m@bues.ch>,
linux-wireless@vger.kernel.org, linux-mips@linux-mips.org,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
Matt Redfearn <matt.redfearn@imgtec.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] ssb: Do not disable PCI host on non-Mips
Date: Fri, 26 Jan 2018 16:37:44 +0200 [thread overview]
Message-ID: <87fu6su1mv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180126100902.GN5446@saruman> (James Hogan's message of "Fri, 26 Jan 2018 10:09:03 +0000")
James Hogan <jhogan@kernel.org> writes:
> On Fri, Jan 26, 2018 at 10:38:01AM +0100, Sven Joachim wrote:
>> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
>> wlan0 interfaces had disappeared. It turns out that the b43 and b44
>> drivers require SSB_PCIHOST_POSSIBLE which depends on
>> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
>>
>> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
>> Cc: stable@vger.org
>> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
>
> Whoops, thats a very good point. I hadn't twigged that
> PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using
> "tig grep" I suppose!).
>
> Reviewed-by: James Hogan <jhogan@kernel.org>
>
> I think this is obviously correct, so it'd be great to squeeze it into
> 4.15 final.
I'm not sure if I'm able to get it to 4.15 as it has go via the net
tree, and we have only two days before the (likely) final release, but
I'll try.
--
Kalle Valo
next prev parent reply other threads:[~2018-01-26 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 9:38 [PATCH] ssb: Do not disable PCI host on non-Mips Sven Joachim
2018-01-26 9:38 ` Sven Joachim
2018-01-26 10:09 ` James Hogan
2018-01-26 14:37 ` Kalle Valo [this message]
2018-01-26 17:01 ` Kalle Valo
2018-01-26 17:45 ` James Hogan
2018-01-26 14:56 ` Kalle Valo
2018-01-26 14:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu6su1mv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=jhogan@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m@bues.ch \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox