From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "Paul Burton" <paulburton@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vladimir Kondratiev" <vladimir.kondratiev@intel.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 07/11] dt-bindings: mfd: syscon: Document EyeQ5 OLB
Date: Mon, 09 Oct 2023 17:49:50 +0200 [thread overview]
Message-ID: <87h6mzbxsx.fsf@BL-laptop> (raw)
In-Reply-To: <20231006165438.GA4061751-robh@kernel.org>
Rob Herring <robh@kernel.org> writes:
> On Wed, Oct 04, 2023 at 06:10:34PM +0200, Gregory CLEMENT wrote:
>> Document Mobileye EyeQ5 compatibles for OLB registers that are
>> misceallanous SoC related registers.
>
> typo.
>
> Please state what OLB is and what kind of things are in this block. IOW,
> convince me this is not just a skeleton placeholder until you add a
> bunch of providers in a real binding.
I understand your concern. First OLB stands for Other Logic Block which
does not say much about it!
It is used to expose SoC specific configuration such as for example
reset, clock or pinctrl. We have a few series nearly ready to be send to
add support for them, each of them will use this block. So declaring
this block since the beginning avoid to have dependencies between these
series and they will only depend of this current initial series.
Is it OK for you ?
Besides fixing the typo I can add the following explanation to the
commit log: "It is used to expose SoC specific configuration such as for
example reset, clock or pinctrl"
Gregory
>
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>> ---
>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 8103154bbb52..70bc6e8d15ba 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -53,6 +53,7 @@ properties:
>> - mediatek,mt8135-pctl-a-syscfg
>> - mediatek,mt8135-pctl-b-syscfg
>> - mediatek,mt8365-syscfg
>> + - mobileye,eyeq5-olb
>> - microchip,lan966x-cpu-syscon
>> - microchip,sparx5-cpu-syscon
>> - mstar,msc313-pmsleep
>> --
>> 2.40.1
>>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2023-10-09 15:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 16:10 [PATCH 00/11] Add support for the Mobileye EyeQ5 SoC Gregory CLEMENT
2023-10-04 16:10 ` [PATCH 01/11] MIPS: compressed: Use correct instruction for 64 bit code Gregory CLEMENT
2023-10-05 6:40 ` Philippe Mathieu-Daudé
2023-10-24 1:49 ` Florian Fainelli
2023-10-04 16:10 ` [PATCH 02/11] MIPS: use virtual addresses from xkphys for MIPS64 Gregory CLEMENT
2023-10-12 15:34 ` Thomas Bogendoerfer
2023-10-22 11:52 ` Jiaxun Yang
2023-10-22 11:39 ` Jiaxun Yang
2023-10-23 15:45 ` Gregory CLEMENT
2023-10-22 16:42 ` Jiaxun Yang
2023-10-24 16:08 ` Gregory CLEMENT
2023-10-04 16:10 ` [PATCH 03/11] MIPS: support RAM beyond 32-bit Gregory CLEMENT
2023-10-06 11:21 ` Arnd Bergmann
2023-10-07 20:14 ` Jiaxun Yang
2023-10-09 15:59 ` Gregory CLEMENT
2023-10-10 8:55 ` Jiaxun Yang
2023-10-11 14:46 ` Gregory CLEMENT
2023-10-12 20:40 ` Jiaxun Yang
2023-10-24 9:05 ` Maciej W. Rozycki
2023-10-04 16:10 ` [PATCH 04/11] dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd Gregory CLEMENT
2023-10-05 6:34 ` Philippe Mathieu-Daudé
2023-10-06 16:32 ` Rob Herring
2023-10-04 16:10 ` [PATCH 05/11] dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core Gregory CLEMENT
2023-10-05 6:31 ` Philippe Mathieu-Daudé
2023-10-05 14:39 ` Serge Semin
2023-10-05 14:51 ` Gregory CLEMENT
2023-10-05 15:23 ` Serge Semin
2023-10-06 10:48 ` Arnd Bergmann
2023-10-06 16:40 ` Rob Herring
2023-10-09 15:32 ` Gregory CLEMENT
2023-10-09 18:48 ` Arnd Bergmann
2023-10-10 10:13 ` Serge Semin
2023-10-05 14:47 ` Sergio Paracuellos
2023-10-04 16:10 ` [PATCH 06/11] dt-bindings: mips: Add bindings for Mobileye SoCs Gregory CLEMENT
2023-10-04 16:47 ` Rob Herring
2023-10-05 14:55 ` Gregory CLEMENT
2023-10-06 16:50 ` Rob Herring
2023-10-04 16:10 ` [PATCH 07/11] dt-bindings: mfd: syscon: Document EyeQ5 OLB Gregory CLEMENT
2023-10-06 16:54 ` Rob Herring
2023-10-09 15:49 ` Gregory CLEMENT [this message]
2023-10-04 16:10 ` [PATCH 08/11] MIPS: mobileye: Add EyeQ5 dtsi Gregory CLEMENT
2023-10-04 16:41 ` Rob Herring
2023-10-05 15:17 ` Gregory CLEMENT
2023-10-04 16:10 ` [PATCH 09/11] MIPS: mobileye: Add EPM5 device tree Gregory CLEMENT
2023-10-06 11:18 ` Arnd Bergmann
2023-10-09 14:51 ` Gregory CLEMENT
2023-10-04 16:10 ` [PATCH 10/11] MIPS: generic: Add support for Mobileye EyeQ5 Gregory CLEMENT
2023-10-05 0:08 ` kernel test robot
2023-10-06 14:47 ` Arnd Bergmann
2023-10-09 14:58 ` Gregory CLEMENT
2023-10-04 16:10 ` [PATCH 11/11] MAINTAINERS: Add entry for Mobileye MIPS SoCs Gregory CLEMENT
2023-10-06 11:11 ` Arnd Bergmann
2023-10-09 15:06 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6mzbxsx.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox