Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Richard Sandiford <rdsandiford@googlemail.com>
To: Maxim Kuvyrkov <maxim@codesourcery.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	gcc-patches@gcc.gnu.org, linux-mips@linux-mips.org
Subject: Re: Changing the treatment of the MIPS HI and LO registers
Date: Wed, 11 Jun 2008 19:54:17 +0100	[thread overview]
Message-ID: <87hcbzx0o6.fsf@firetop.home> (raw)
In-Reply-To: <48501C55.5060602@codesourcery.com> (Maxim Kuvyrkov's message of "Wed\, 11 Jun 2008 22\:41\:25 +0400")

Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> GLIBC contains the following code in stdlib/longlong.h:
> <snip>
> #if defined (__mips__) && W_TYPE_SIZE == 32
> #define umul_ppmm(w1, w0, u, v) \
>    __asm__ ("multu %2,%3"						\
> 	   : "=l" ((USItype) (w0)),					\
> 	     "=h" ((USItype) (w1))					\
> 	   : "d" ((USItype) (u)),					\
> 	     "d" ((USItype) (v)))
> #define UMUL_TIME 10
> #define UDIV_TIME 100
> #endif /* __mips__ */
> </snip>
>
> What would be a correct fix in this case?  Something like this:
> <snip>
> #define umul_ppmm(w1, w0, u, v)					\
>    ({unsigned int __attribute__((mode(DI))) __xx;		\
>      __xx = (unsigned int __attribute__((mode(DI)))) u * v;	\
>      w0 = __xx & ((1 << 32) - 1);				\
>      w1 = __xx >> 32;})
> </snip>
>
> Or is there a better way?

All being well, you should just be able to do the same as I did for
GCC's copy of longlong.h (included in the patch you responded to).

Richard

  reply	other threads:[~2008-06-11 18:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87tzgj4nh6.fsf@firetop.home>
     [not found] ` <Pine.LNX.4.55.0805272134540.18833@cliff.in.clinika.pl>
     [not found]   ` <87abib4d9t.fsf@firetop.home>
     [not found]     ` <Pine.LNX.4.55.0805272357020.18833@cliff.in.clinika.pl>
     [not found]       ` <87r6bm1ebd.fsf@firetop.home>
2008-05-29  2:01         ` Changing the treatment of the MIPS HI and LO registers Maciej W. Rozycki
     [not found]           ` <878wxtvarg.fsf@firetop.home>
2008-06-01 13:48             ` Richard Sandiford
2008-06-09 21:13               ` Richard Sandiford
2008-06-09 21:54                 ` Maciej W. Rozycki
2008-06-11 18:41                 ` Maxim Kuvyrkov
2008-06-11 18:54                   ` Richard Sandiford [this message]
2008-06-11 23:24                   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hcbzx0o6.fsf@firetop.home \
    --to=rdsandiford@googlemail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=maxim@codesourcery.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox