Re: [PATCH v4 19/19] irqdomain: Switch to per-domain locking

Thomas Gleixner
2023-01-18T13:40:30Z

On Wed, Jan 18 2023 at 10:51, Johan Hovold wrote:
> On Tue, Jan 17, 2023 at 10:50:39PM +0100, Thomas Gleixner wrote:
>> On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote:
>> > The IRQ domain structures are currently protected by the global
>> > irq_domain_mutex. Switch to using more fine-grained per-domain locking,
>> > which may potentially speed up parallel probing somewhat.
>>
>> Does it or not?
>>
>> If not then why adding all this churn for no real value?
>
> It probably doesn't make much difference, but Marc wanted per-domain
> locking:
>
> > I'd really like to avoid a global mutex. At the very least this should
> > be a per-domain mutex, otherwise this will serialise a lot more than
> > what is needed.

Sure it serializes more than what is needed, but the real question is
whether it matters. If it does not matter then I prefer KISS over a just
because we can optimization.

Thanks,

tglx