From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5353EB64DA for ; Wed, 12 Jul 2023 11:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbjGLLTH (ORCPT ); Wed, 12 Jul 2023 07:19:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233041AbjGLLTG (ORCPT ); Wed, 12 Jul 2023 07:19:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 636CB1BCC for ; Wed, 12 Jul 2023 04:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689160698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mGmoSdcAtbAnvFmDIfmKNE01xrI5yfsr2LA1G6eD+Js=; b=f2fWtkj1LtrxD+IttWyX5MCLcC3bszR/WsYFmF7AD6zqZLTsXXiFqojcdJQPtW5LEtLVuu y/wdn8BhEcN24SZEdygkwLGIu4gC+RUQgWckR1pjXbw8mo8NpjV59yYpRyL3T815/rv4HB Oh9B6AqYpdqMXT9deBue06e65OuHnTc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-gLo6Wx2eP3mzn2RL9XNDdA-1; Wed, 12 Jul 2023 07:18:17 -0400 X-MC-Unique: gLo6Wx2eP3mzn2RL9XNDdA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3144bf68a03so3846633f8f.2 for ; Wed, 12 Jul 2023 04:18:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689160696; x=1691752696; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mGmoSdcAtbAnvFmDIfmKNE01xrI5yfsr2LA1G6eD+Js=; b=d0iDPeRbw3KlqQNpGRs5t/F1Yr3xM09loq8mUaxSHx1NJ9GQ6bpSVUhVCPsPjrZfNJ mczbpBLgkqO/DNsQfLKyhCS9xqdCZaqg/uNn+zaKKsaU7v31z+lHV8zDKhfq9WE1XCG0 D+Nf2rK8hDMSo/FZT4PqPjovm/jjFstA2YtBv4VqnE6CYz/ZwKTm0/KOxB3VRYSM8RNc NWNNkGYCMehm72op5AnwyWYRCsSVIxO4Mpkdxh0Qv7oKr0kTS0vDBaemQbfTitH1yXfs JK9TRkZOVkBMIkaJy766TeiIrsL+PqxZ5Ul2RRgzkKgXjpPa12jyOpSeWjNBITgNJoOt 4Ghw== X-Gm-Message-State: ABy/qLYgUJh23ylIvmooTFQlmdBoPQSx96Przdu153832pyFCJigxYUy GXUpyU5wB3lSGcD8MGIevbZFcGwy15xxwcg5ZXTHKz0kVyMAe5j2s1UHCyQimJgXe4ysesIJ4w6 70TlrqrIETe46K7U+x3KPwQ== X-Received: by 2002:a05:600c:3644:b0:3fc:627:ea31 with SMTP id y4-20020a05600c364400b003fc0627ea31mr12056757wmq.38.1689160695900; Wed, 12 Jul 2023 04:18:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHe6rz0BytbzD5//h/wnxrk0jp/oOEOt3AbTKSXStRClYkvIUVNGHa0orOjttguAlZUCgSKTg== X-Received: by 2002:a05:600c:3644:b0:3fc:627:ea31 with SMTP id y4-20020a05600c364400b003fc0627ea31mr12056740wmq.38.1689160695625; Wed, 12 Jul 2023 04:18:15 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id k6-20020a05600c0b4600b003fc00702f65sm14151776wmr.46.2023.07.12.04.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 04:18:15 -0700 (PDT) From: Javier Martinez Canillas To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Thomas Zimmermann Cc: linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, Xinwei Kong , VMware Graphics Reviewers , NXP Linux Team , spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, Gurchetan Singh , Sean Paul , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-mips@vger.kernel.org, Chia-I Wu , linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, John Stultz , freedreno@lists.freedesktop.org, Lucas Stach Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev In-Reply-To: <20230712105432.urgwb4zzwgsyfbwq@pengutronix.de> References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <20230712105432.urgwb4zzwgsyfbwq@pengutronix.de> Date: Wed, 12 Jul 2023 13:18:14 +0200 Message-ID: <87r0pdgyyx.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Uwe Kleine-K=C3=B6nig writes: [dropping some recipients since my SMTP server was complaining about the si= ze] > Hello Thomas, > > On Wed, Jul 12, 2023 at 12:19:37PM +0200, Thomas Zimmermann wrote: >> Am 12.07.23 um 11:46 schrieb Uwe Kleine-K=C3=B6nig: >> > Hello, >> >=20 >> > while I debugged an issue in the imx-lcdc driver I was constantly >> > irritated about struct drm_device pointer variables being named "dev" >> > because with that name I usually expect a struct device pointer. >> >=20 >> > I think there is a big benefit when these are all renamed to "drm_dev". >>=20 >> If you rename drm_crtc.dev, you should also address *all* other data >> structures. > > Yes. Changing drm_crtc::dev was some effort, so I thought to send that > one out before doing the same to > > drm_dp_mst_topology_mgr > drm_atomic_state > drm_master > drm_bridge > drm_client_dev > drm_connector > drm_debugfs_entry > drm_encoder > drm_fb_helper > drm_minor > drm_framebuffer > drm_gem_object > drm_plane > drm_property > drm_property_blob > drm_vblank_crtc > > when in the end the intention isn't welcome. > >> > I have no strong preference here though, so "drmdev" or "drm" are fine >> > for me, too. Let the bikesheding begin! >>=20 >> We've discussed this to death. IIRC 'drm' would be the prefered choice. > > "drm" at least has the advantage to be the 2nd most common name. With > Paul Kocialkowski prefering "drm_dev" there is no clear favourite yet. I think that either "drm" or "drm_dev" would be more clear than "dev", which I also found it confusing and thinking about a "struct device". Probably leaning to "drm", since as you said is the second most used name in drivers that assign crtc->dev to a local variable. > Maybe all the other people with strong opinions are dead if this was > "discussed to death" before? :-) > > Best regards > Uwe > > --=20 > Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | > Industrial Linux Solutions | https://www.pengutronix.de/ | --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat