From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A91C001B1 for ; Thu, 15 Jun 2023 22:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbjFOWDq (ORCPT ); Thu, 15 Jun 2023 18:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231231AbjFOWDh (ORCPT ); Thu, 15 Jun 2023 18:03:37 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1942B2D6B; Thu, 15 Jun 2023 15:03:33 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686866611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WePTMyE45qwE++8TRrjkwtysmPUcOS3LgW/k38AkuSI=; b=BFrLebSkFNVOCzT2IpgGiJ0Pvwl4C6rJQWMOuiT+63wINu33JzO78MU9TYGFMlnWUXyAUh Xhk4wm8ZUtG+W8XJ1HYlTbHql0VJge25Ax5kGvVg+m6ndfrxbxGCAKdspD5x5j4TmDVxGW hz23M3Hz+IqqiDWtpbQps8Ylv0FhHNkVJiImy19cXSnE3P8f2RAAZmjZTovqVh5T0zERE4 P/0Lx/U4+CDx5K5TMi5xFn2XRxKyjm/1lX7z1RJvE4XZO349M91G/jWdnDwbBd8z42Bqhr R8YBEF4GMDQ+PIIUcGwC4fRAq2j8jxS43fkmJxExYShf33Zc0q093qDMYhFKxw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686866611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WePTMyE45qwE++8TRrjkwtysmPUcOS3LgW/k38AkuSI=; b=6iNPBBEFXbFtS5Ao2dawxcNVDyr/qHhbmKNIDyn3HuL1jxxTrLdZSnDkEAT/K1svJmXSNt QPnvP4lcgbb0l9Ag== To: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" Cc: "chenhuacai@kernel.org" , "darwi@linutronix.de" , "linux-ia64@vger.kernel.org" , "glaubitz@physik.fu-berlin.de" , "Torvalds, Linus" , "chris@zankel.net" , "ysato@users.sourceforge.jp" , "davem@davemloft.net" , "thomas.lendacky@amd.com" , "James.Bottomley@HansenPartnership.com" , "mpe@ellerman.id.au" , "kernel@xen0n.name" , "linux-sh@vger.kernel.org" , "dalias@libc.org" , "loongarch@lists.linux.dev" , "linux@armlinux.org.uk" , "linux-m68k@lists.linux-m68k.org" , "nik.borisov@suse.com" , "arnd@arndb.de" , "anton.ivanov@cambridgegreys.com" , "sparclinux@vger.kernel.org" , "richard@nod.at" , "johannes@sipsolutions.net" , "linux-um@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "tsbogend@alpha.franken.de" , "linux-mips@vger.kernel.org" , "richard.henderson@linaro.org" , "geert@linux-m68k.org" , "x86@kernel.org" Subject: Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier In-Reply-To: References: <20230613223827.532680283@linutronix.de> <20230613224545.612182854@linutronix.de> Date: Fri, 16 Jun 2023 00:03:30 +0200 Message-ID: <87sfas758t.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote: > On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote: >> Fortunately none of the init calls between calibrate_delay() and >> arch_cpu_finalize_init() is relevant for the functionality of >> arch_cpu_finalize_init(). >> > > Reviewed-by: Rick Edgecombe > > I did my best to find a counterpoint to this statement. The only thing > I found was that lockdep_init_task(&init_task) in fork_init() is now > called after the spin_lock() usage in set_memory_4k(). > > But AFAICT, that whole lockdep_init_task() call is unneeded because > the fields it sets are already statically initialized. Correct. The call there looks absolute pointless. Peter?