From: NeilBrown <neil@brown.name>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>, hauke@hauke-m.de
Cc: paul.burton@mips.com, linux-mips@vger.kernel.org, ralf@linux-mips.org
Subject: Re: PCI support for SOC_MT7621
Date: Thu, 17 Oct 2019 08:57:00 +1100 [thread overview]
Message-ID: <87v9sopd5f.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAMhs-H93MvRBPpR2ra33wf667V_wyDmQGWY0n_rB=puq_aBGog@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Wed, Oct 16 2019, Sergio Paracuellos wrote:
> Hi all,
>
> I have a concern about commit:
>
> c4d48cf5e2f0 ("MIPS: ralink: deactivate PCI support for SOC_MT7621")
>
> This commit make a regression for my kernel configuration for gnubee
> board which is mt7621 SOC based and also has PCI. With this applied
> PCI_DRIVERS_GENERIC is not selectable anymore and it becomes into a
> PCI_DRIVERS_LEGACY configuration making impossible to compile
> mt7621-pci driver for this board.
>
> I think this should be reverted. Am I missing something here?
The commit reports a build error without the patch, and we don't want
that.
Maybe change the
select HAVE_PCI
to
select HAVE_PCI if STAGING
or
select HAVE_PCI if PCI_MT7621
Hauke: do either of those fix your compile error?
Thanks,
NeilBrown
>
> Thanks in advance for your time.
>
> Best regards,
> Sergio Paracuellos
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-10-16 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:31 PCI support for SOC_MT7621 Sergio Paracuellos
2019-10-16 21:57 ` NeilBrown [this message]
2019-10-17 6:12 ` Sergio Paracuellos
2019-10-17 11:36 ` Sergio Paracuellos
2019-10-19 8:12 ` [PATCH] MIPS: ralink: enable PCI support only if driver for mt7621 SoC is selected Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9sopd5f.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=hauke@hauke-m.de \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox