From: Richard Sandiford <rsandifo@redhat.com>
To: Richard Henderson <rth@redhat.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Nigel Stephens <nigel@mips.com>,
gcc-patches@gcc.gnu.org, linux-mips@linux-mips.org
Subject: Re: [patch] MIPS/gcc: Revert removal of DImode shifts for 32-bit targets
Date: Tue, 10 Aug 2004 06:30:28 +0100 [thread overview]
Message-ID: <87zn5336h7.fsf@redhat.com> (raw)
In-Reply-To: <20040809220838.GE16493@redhat.com> (Richard Henderson's message of "Mon, 9 Aug 2004 15:08:38 -0700")
Richard Henderson <rth@redhat.com> writes:
> On Sat, Aug 07, 2004 at 08:01:43PM +0100, Richard Sandiford wrote:
>> + do_compare_rtx_and_jump (cmp1, cmp2, cmp_code, true, op1_mode,
>> + 0, 0, subword_label);
>> +
>> + if (!expand_superword_shift (op1_mode, binoptab,
>> + outof_input, op1,
>> + outof_target, into_target,
>> + unsignedp, methods))
>> + return false;
>
> Return without cleaning up the branch emitted? In particular,
> doing so without emitting the labels will result in ICEs.
The whole thing's in a sequence that gets discarded if
expand_doubleword_shift returns false. Isn't that enough?
Richad
next prev parent reply other threads:[~2004-08-10 5:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-19 15:35 [patch] MIPS/gcc: Revert removal of DImode shifts for 32-bit targets Maciej W. Rozycki
2004-07-19 16:59 ` Richard Sandiford
2004-07-19 17:32 ` [patch] MIPS/gcc: Revert removal of DImode shifts for 32-bittargets David Edelsohn
2004-07-19 17:33 ` [patch] MIPS/gcc: Revert removal of DImode shifts for 32-bit targets Maciej W. Rozycki
2004-07-19 17:37 ` Richard Sandiford
2004-07-19 21:38 ` Richard Henderson
2004-07-23 14:41 ` Maciej W. Rozycki
2004-07-23 20:27 ` Richard Henderson
2004-07-23 21:12 ` Ralf Baechle
2004-07-26 11:56 ` Maciej W. Rozycki
2004-08-02 20:03 ` Nigel Stephens
2004-08-03 5:30 ` Richard Sandiford
2004-08-03 9:22 ` Nigel Stephens
2004-08-03 9:36 ` Richard Sandiford
2004-08-03 9:54 ` Nigel Stephens
2004-08-04 19:57 ` Maciej W. Rozycki
2004-08-04 20:37 ` Nigel Stephens
2004-08-04 20:54 ` Maciej W. Rozycki
2004-08-04 23:39 ` Nigel Stephens
2004-08-07 19:01 ` Richard Sandiford
2004-08-09 22:08 ` Richard Henderson
2004-08-10 5:30 ` Richard Sandiford [this message]
2004-08-10 23:20 ` Richard Henderson
2004-08-11 0:24 ` Andreas Schwab
2004-08-11 0:40 ` Paul Brook
2004-08-11 4:32 ` Richard Henderson
2004-08-31 19:51 ` Richard Sandiford
2004-09-03 6:53 ` Richard Henderson
2004-09-03 7:05 ` Richard Sandiford
2004-09-03 7:08 ` Richard Henderson
2004-09-03 7:11 ` Richard Sandiford
2004-09-03 7:20 ` Richard Henderson
2004-09-03 7:29 ` Richard Sandiford
2004-09-03 20:15 ` Richard Henderson
2004-09-04 8:53 ` Richard Sandiford
2004-09-05 0:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zn5336h7.fsf@redhat.com \
--to=rsandifo@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=nigel@mips.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox