* Re: Build regressions/improvements in v6.5-rc3 [not found] ` <20230724122626.1701631-1-geert@linux-m68k.org> @ 2023-07-24 12:43 ` Geert Uytterhoeven 2023-07-28 22:57 ` Kees Cook 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2023-07-24 12:43 UTC (permalink / raw) To: linux-kernel Cc: Kees Cook, Gustavo A. R. Silva, linux-hardening, linux-wireless, linux-mips, linux-mtd, linux-parisc, linux-sh On Mon, 24 Jul 2023, Geert Uytterhoeven wrote: > JFYI, when comparing v6.5-rc3[1] to v6.5-rc2[3], the summaries are: > - build errors: +5/-0 + /kisskb/src/include/linux/fortify-string.h: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]: => 583:25, 493:25 mips-gcc13/mips-allmodconfig Full context: In function 'fortify_memset_chk', inlined from 'memset_io' at /kisskb/src/arch/mips/include/asm/io.h:486:2, inlined from 'build_auth_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:2697:2: /kisskb/src/include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] 493 | __write_overflow_field(p_size_field, size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'fortify_memcpy_chk', inlined from 'memcpy_toio' at /kisskb/src/arch/mips/include/asm/io.h:494:2, inlined from 'translate_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:955:3, inlined from 'ray_hw_xmit.constprop' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:912:12: /kisskb/src/include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] 583 | __write_overflow_field(p_size_field, size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Single-element flexible array abuse in drivers/net/wireless/legacy/rayctl.h:tx_msg.var + error: modpost: ".L856" [drivers/mtd/nand/raw/nand.ko] undefined!: => N/A parisc-gcc13/parisc-allmodconfig + {standard input}: Error: Missing symbol name in directive: => 1096 + {standard input}: Error: unrecognized symbol type "": => 1096 sh4-gcc12/sh-allmodconfig (ICE) + {standard input}: Error: unknown opcode: => 1091 sh4-gcc13/sh-allmodconfig (ICE) > [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/6eaae198076080886b9e7d57f4ae06fa782f90ef/ (all 235 configs) > [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fdf0eaf11452d72945af31804e2a1048ee1b574c/ (161 out of 235 configs) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.5-rc3 2023-07-24 12:43 ` Build regressions/improvements in v6.5-rc3 Geert Uytterhoeven @ 2023-07-28 22:57 ` Kees Cook 2023-08-14 16:20 ` Geert Uytterhoeven 0 siblings, 1 reply; 4+ messages in thread From: Kees Cook @ 2023-07-28 22:57 UTC (permalink / raw) To: Geert Uytterhoeven Cc: linux-kernel, Gustavo A. R. Silva, linux-hardening, linux-wireless, linux-mips, linux-mtd, linux-parisc, linux-sh On Mon, Jul 24, 2023 at 02:43:02PM +0200, Geert Uytterhoeven wrote: > On Mon, 24 Jul 2023, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.5-rc3[1] to v6.5-rc2[3], the summaries are: > > - build errors: +5/-0 > > + /kisskb/src/include/linux/fortify-string.h: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]: => 583:25, 493:25 > > mips-gcc13/mips-allmodconfig > > Full context: > > In function 'fortify_memset_chk', > inlined from 'memset_io' at /kisskb/src/arch/mips/include/asm/io.h:486:2, > inlined from 'build_auth_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:2697:2: > /kisskb/src/include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > 493 | __write_overflow_field(p_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In function 'fortify_memcpy_chk', > inlined from 'memcpy_toio' at /kisskb/src/arch/mips/include/asm/io.h:494:2, > inlined from 'translate_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:955:3, > inlined from 'ray_hw_xmit.constprop' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:912:12: > /kisskb/src/include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > 583 | __write_overflow_field(p_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Single-element flexible array abuse in drivers/net/wireless/legacy/rayctl.h:tx_msg.var ^^^^ is this line from you or is there a tool outputting this? Because, yes, very true: struct tx_msg { struct tib_structure tib; struct phy_header phy; struct mac_header mac; UCHAR var[1]; }; I'll send a patch. -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.5-rc3 2023-07-28 22:57 ` Kees Cook @ 2023-08-14 16:20 ` Geert Uytterhoeven 2023-08-14 19:00 ` Kees Cook 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2023-08-14 16:20 UTC (permalink / raw) To: Kees Cook Cc: linux-kernel, Gustavo A. R. Silva, linux-hardening, linux-wireless, linux-mips, linux-mtd, linux-parisc, linux-sh Hi Kees, On Sat, Jul 29, 2023 at 12:57 AM Kees Cook <keescook@chromium.org> wrote: > On Mon, Jul 24, 2023 at 02:43:02PM +0200, Geert Uytterhoeven wrote: > > On Mon, 24 Jul 2023, Geert Uytterhoeven wrote: > > > JFYI, when comparing v6.5-rc3[1] to v6.5-rc2[3], the summaries are: > > > - build errors: +5/-0 > > > > + /kisskb/src/include/linux/fortify-string.h: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]: => 583:25, 493:25 > > > > mips-gcc13/mips-allmodconfig > > > > Full context: > > > > In function 'fortify_memset_chk', > > inlined from 'memset_io' at /kisskb/src/arch/mips/include/asm/io.h:486:2, > > inlined from 'build_auth_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:2697:2: > > /kisskb/src/include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > > 493 | __write_overflow_field(p_size_field, size); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In function 'fortify_memcpy_chk', > > inlined from 'memcpy_toio' at /kisskb/src/arch/mips/include/asm/io.h:494:2, > > inlined from 'translate_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:955:3, > > inlined from 'ray_hw_xmit.constprop' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:912:12: > > /kisskb/src/include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > > 583 | __write_overflow_field(p_size_field, size); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Single-element flexible array abuse in drivers/net/wireless/legacy/rayctl.h:tx_msg.var > > ^^^^ > is this line from you or is there a tool outputting this? Because, yes, It is a line from me. (should I take it as a compliment that I start sounding like a tool? ;-) > very true: > > struct tx_msg { > struct tib_structure tib; > struct phy_header phy; > struct mac_header mac; > UCHAR var[1]; > }; > > I'll send a patch. Thanks, I noticed you took care while I was enjoying summer holidays ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build regressions/improvements in v6.5-rc3 2023-08-14 16:20 ` Geert Uytterhoeven @ 2023-08-14 19:00 ` Kees Cook 0 siblings, 0 replies; 4+ messages in thread From: Kees Cook @ 2023-08-14 19:00 UTC (permalink / raw) To: Geert Uytterhoeven Cc: linux-kernel, Gustavo A. R. Silva, linux-hardening, linux-wireless, linux-mips, linux-mtd, linux-parisc, linux-sh On Mon, Aug 14, 2023 at 06:20:59PM +0200, Geert Uytterhoeven wrote: > Hi Kees, > > On Sat, Jul 29, 2023 at 12:57 AM Kees Cook <keescook@chromium.org> wrote: > > On Mon, Jul 24, 2023 at 02:43:02PM +0200, Geert Uytterhoeven wrote: > > > On Mon, 24 Jul 2023, Geert Uytterhoeven wrote: > > > > JFYI, when comparing v6.5-rc3[1] to v6.5-rc2[3], the summaries are: > > > > - build errors: +5/-0 > > > > > > + /kisskb/src/include/linux/fortify-string.h: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]: => 583:25, 493:25 > > > > > > mips-gcc13/mips-allmodconfig > > > > > > Full context: > > > > > > In function 'fortify_memset_chk', > > > inlined from 'memset_io' at /kisskb/src/arch/mips/include/asm/io.h:486:2, > > > inlined from 'build_auth_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:2697:2: > > > /kisskb/src/include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > > > 493 | __write_overflow_field(p_size_field, size); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > In function 'fortify_memcpy_chk', > > > inlined from 'memcpy_toio' at /kisskb/src/arch/mips/include/asm/io.h:494:2, > > > inlined from 'translate_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:955:3, > > > inlined from 'ray_hw_xmit.constprop' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:912:12: > > > /kisskb/src/include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > > > 583 | __write_overflow_field(p_size_field, size); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Single-element flexible array abuse in drivers/net/wireless/legacy/rayctl.h:tx_msg.var > > > > ^^^^ > > is this line from you or is there a tool outputting this? Because, yes, > > It is a line from me. > > (should I take it as a compliment that I start sounding like a tool? ;-) Heh. It was so declaratory. :) I think I was hoping there was some analyzer that could save us the pain of manually examining these warnings. > > > very true: > > > > struct tx_msg { > > struct tib_structure tib; > > struct phy_header phy; > > struct mac_header mac; > > UCHAR var[1]; > > }; > > > > I'll send a patch. > > Thanks, I noticed you took care while I was enjoying summer holidays ;-) Awesome! Thanks for the report. :) -- Kees Cook ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-14 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAHk-=wi4Yau-3Bsv2rXYmtXMTLaj3=Wyf4cdM6d89czFvkVsRQ@mail.gmail.com>
[not found] ` <20230724122626.1701631-1-geert@linux-m68k.org>
2023-07-24 12:43 ` Build regressions/improvements in v6.5-rc3 Geert Uytterhoeven
2023-07-28 22:57 ` Kees Cook
2023-08-14 16:20 ` Geert Uytterhoeven
2023-08-14 19:00 ` Kees Cook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).