From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED121E5718 for ; Wed, 19 Feb 2025 09:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739956631; cv=none; b=kOScd46jj80EDhpogAXx3RuQ/a4Bs5JV4hXVcTtAuDTzSWDQeh09rVBKXEupN62GoqssOZYp9uXuddMpH5aoG9TE8H25VV7v1IhbKtnRt9Lqcvl0OvPUm+0aV2oPU8NMQQdtK1XKTYg3kgtPoSMCp9m5svtQ8CcyOBhcBnR4KQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739956631; c=relaxed/simple; bh=HMZQPXlE/GBYUYWDCXKq+y9Wkg3KfJTtuU7DIfPDt9M=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UfmrVqL6UUQ/5Y13bJPY+Z6yPPSddlzAfFyThmnUX1l3uUgfpQywtw0s1IDU9j7fCxKFGyOkrIfazFndtcxTc5vjy6daplSot7i7VJhzTUa4DeiLStEOPu8mvumpaRWMkuEs4vXuhd8b1sGVF+USNfHKyzVFXCDQ3PxvA8HWibM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tkgBq-00054h-Ak; Wed, 19 Feb 2025 10:16:22 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tkgBp-001jq7-2H; Wed, 19 Feb 2025 10:16:21 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1tkgBp-0002qA-1n; Wed, 19 Feb 2025 10:16:21 +0100 Message-ID: <89d52c01503e2dbd2e23cce1ff9eb037e59eec5a.camel@pengutronix.de> Subject: Re: [PATCH v4 6/8] reset: eyeq: drop device_set_of_node_from_dev() done by parent From: Philipp Zabel To: Jerome Brunet , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , "Rafael J. Wysocki" , Stephen Boyd , Arnd Bergmann , Danilo Krummrich , Conor Dooley , Daire McNamara , Douglas Anderson , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Bryan O'Donoghue , Vladimir Kondratiev , Gregory CLEMENT , =?ISO-8859-1?Q?Th=E9o?= Lebrun , Michael Turquette , Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Kevin Hilman , Martin Blumenstingl Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Date: Wed, 19 Feb 2025 10:16:21 +0100 In-Reply-To: <20250218-aux-device-create-helper-v4-6-c3d7dfdea2e6@baylibre.com> References: <20250218-aux-device-create-helper-v4-0-c3d7dfdea2e6@baylibre.com> <20250218-aux-device-create-helper-v4-6-c3d7dfdea2e6@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org On Di, 2025-02-18 at 20:29 +0100, Jerome Brunet wrote: > From: Th=C3=A9o Lebrun >=20 > Our parent driver (clk-eyeq) now does the > device_set_of_node_from_dev(dev, dev->parent) > call through the newly introduced devm_auxiliary_device_create() helper. >=20 > Doing it again in the reset-eyeq probe would be redundant. > Drop both the WARN_ON() and the device_set_of_node_from_dev() call. > Also fix the following comment that talks about "our newfound OF node". >=20 > Signed-off-by: Th=C3=A9o Lebrun > Signed-off-by: Jerome Brunet Reviewed-by: Philipp Zabel regards Philipp