From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E026AC6FD1D for ; Mon, 20 Mar 2023 10:32:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbjCTKcX (ORCPT ); Mon, 20 Mar 2023 06:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbjCTKcA (ORCPT ); Mon, 20 Mar 2023 06:32:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB04011EB0 for ; Mon, 20 Mar 2023 03:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679308225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BgE1X4ekUlT0hc9XsprdaHvSq6/U0b4NczzgHQA4c5o=; b=HBH+LEJu5nKP2hQ5j/lmGhDU2oeg3EJx0Zl2minj/jmJrQAK2ZeeV5NsmMk0wcy5vZAAou /RLk7NiEE4gZtKXWVV8FqC+lBBRn5/0dsAJn2/gKrvrwpCA9EALMTJ22C88j2QFmHWkQjU jbd5Tz0MGWPQwCIhSgfOmKE3NYDvTDg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-5WDd0aYFO2ypvGzExJYwxA-1; Mon, 20 Mar 2023 06:30:24 -0400 X-MC-Unique: 5WDd0aYFO2ypvGzExJYwxA-1 Received: by mail-wm1-f72.google.com with SMTP id m30-20020a05600c3b1e00b003ed31d151ecso4233001wms.1 for ; Mon, 20 Mar 2023 03:30:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679308223; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BgE1X4ekUlT0hc9XsprdaHvSq6/U0b4NczzgHQA4c5o=; b=cOJaIqaEM4aBisW6Cn3DruxpqnnIm1mPZi7BDHsTRQ8Ddqnx+nzFy7kQgNtqIXpwId FEUdCRNV1muiHFJnhtEkRRDWI6SaWYsHCLBH1Dkjxv/RXiKWF/oEHDyzUDsM0nHWT79G aUjIzj2eLUG5ehMVNtBCJuK2Gvv3jUp599XkpvoWef4EIUGfuTb+ygePZacDMhEntmQx hdaR/Yhh7pAhjLXgPoWtKDC3JlBkhm+CnR2b9NwFfE8NWumQz9a9vMpyf6Bj3pM3u6VM yumgJ2N5dRtSLVd2SPgYVE26TtQ9HmyB29mKfbjW/c7w9KfTgME57inSFbhuy4ewYKjt ygEQ== X-Gm-Message-State: AO0yUKU7trCR673nfwmHHv2YC1nAG6nW5bKiRNHW1xTAN++1FJcBI6RM kHoyHFhriQ5sFE0wWBfVybo9ezANhTZr2HAl+mMvTV1MuGjEgAtpfMaF5mq2qfA/70y0IB3NLMM Q1s+MpvkJiT1DNDFhbkl6qw== X-Received: by 2002:a5d:504c:0:b0:2cd:f2c6:5d37 with SMTP id h12-20020a5d504c000000b002cdf2c65d37mr12507927wrt.5.1679308223078; Mon, 20 Mar 2023 03:30:23 -0700 (PDT) X-Google-Smtp-Source: AK7set/fN142O0jmW4iqCLPXtEiyw9GviYWHg1q3pkSYIopaetrIf+KQV8h0TcW9SYuysz31BfdDJw== X-Received: by 2002:a5d:504c:0:b0:2cd:f2c6:5d37 with SMTP id h12-20020a5d504c000000b002cdf2c65d37mr12507909wrt.5.1679308222659; Mon, 20 Mar 2023 03:30:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id b7-20020a5d4b87000000b002cfe0ab1246sm8565121wrt.20.2023.03.20.03.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:30:21 -0700 (PDT) Message-ID: <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> Date: Mon, 20 Mar 2023 11:30:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230319220008.2138576-3-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 19.03.23 22:59, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > init_cma_reserved_pages() only used in cma.c, no point of having it in > page_alloc.c. > > Move init_cma_reserved_pages() to cma.c and make it static. I guess the motivation is to avoid letting too many subsystems mess with pageblock migratetypes, managed pages, PG_reserved ... So it kind of makes sense to have these low-level details out of common CMA code, no? -- Thanks, David / dhildenb