From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688CD225A2 for ; Wed, 26 Jun 2024 14:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719411054; cv=none; b=b/axjK+2AW99fe8yZMbJpD32srKGIgwAvIRhpAxsSZYNV7Ablvoaj5LPgSJcrRzHHvGkzS28Hy9qYkNfxZVspGTZw873GVJ3m2vfgHEhphLRE10/K5OoBXZEZv7O9qxNyoF71+94iuighmSt5zQuYW2MVrg2YZ8rwW8xZz9h3VA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719411054; c=relaxed/simple; bh=WYPpi0PRU/8DfWUsZxGzlqqtmDQV7dcd1f8cYkoIt98=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=c+m8Pv3R7DVK3NkubuAGTItjHaeLw351TIhkYvtNXTwyYHQxFAj8hrUiyxVpJY2WOtdtz/0+ibtRn4rt38Eh0XZJdwe5E/S9lzEd13/3BMjpf4Tnfn1P95Gjx/xM2TqUuwjSkHPDnDzFbk9J3yhovd1U/q/Hqf7UECQi+mvT6oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMTM5-0003BI-A2; Wed, 26 Jun 2024 16:10:37 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMTM4-0059Aa-7G; Wed, 26 Jun 2024 16:10:36 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sMTM4-000C0z-0S; Wed, 26 Jun 2024 16:10:36 +0200 Message-ID: <8d7ea409a4e1a6cfcbee7f493c9073b172cc100d.camel@pengutronix.de> Subject: Re: [PATCH v3 7/9] reset: eyeq: add platform driver From: Philipp Zabel To: =?ISO-8859-1?Q?Th=E9o?= Lebrun , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Linus Walleij , Greg Kroah-Hartman , "Rafael J. Wysocki" , Lee Jones , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, Vladimir Kondratiev , Gregory CLEMENT , Thomas Petazzoni , Tawfik Bayouk Date: Wed, 26 Jun 2024 16:10:36 +0200 In-Reply-To: References: <20240620-mbly-olb-v3-0-5f29f8ca289c@bootlin.com> <20240620-mbly-olb-v3-7-5f29f8ca289c@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org Hi Th=C3=A9o, On Mi, 2024-06-26 at 15:55 +0200, Th=C3=A9o Lebrun wrote: > Hello Philipp, >=20 > On Tue Jun 25, 2024 at 11:17 AM CEST, Philipp Zabel wrote: > > On Do, 2024-06-20 at 19:30 +0200, Th=C3=A9o Lebrun wrote: > > > Add Mobileye EyeQ reset controller driver, for EyeQ5, EyeQ6L and EyeQ= 6H > > > SoCs. Instances belong to a shared register region called OLB and get= s > > > spawned as auxiliary device to the platform driver for clock. > > >=20 > > > There is one OLB instance for EyeQ5 and EyeQ6L. There are seven OLB > > > instances on EyeQ6H; three have a reset controller embedded: > > > - West and east get handled by the same compatible. > > > - Acc (accelerator) is another one. > > >=20 > > > Each instance vary in the number and types of reset domains. > > > Instances with single domain expect a single cell, others two. > > >=20 > > > Signed-off-by: Th=C3=A9o Lebrun > > > --- > > > MAINTAINERS | 1 + > > > drivers/reset/Kconfig | 14 ++ > > > drivers/reset/Makefile | 1 + > > > drivers/reset/reset-eyeq.c | 563 +++++++++++++++++++++++++++++++++++= ++++++++++ > >=20 > > Should this be called reset-eyeq-olb or reset-eyeq5, in case a > > different eyeq driver will have to be added in the future? >=20 > What about keeping reset-eyeq for the simplicity of it and using > reset-eyeq7 for a theoretical future driver that gets used by EyeQ7 and > above? Or any other revision. >=20 > Else it can be reset-eyeq5. OLB might be a concept that gets reused with > different reset blocks inside (meaning reset-eyeq-olb wouldn't > distinguish). You tell me if keeping *-eyeq is fine. Either is fine by me. I just wanted to make sure this was given some consideration after noticing the reset-eyeq5.c remnant in MAINTAINERS. regards Philipp