From: Allen Pais <apais@linux.microsoft.com>
To: Dhananjay Phadke <dphadke@linux.microsoft.com>,
allen.lkml@gmail.com, jens.wiklander@linaro.org,
zajec5@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
op-tee@lists.trustedfirmware.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot
Date: Mon, 22 Feb 2021 18:15:08 +0530 [thread overview]
Message-ID: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com> (raw)
In-Reply-To: <20210217092714.121297-2-allen.lkml@gmail.com>
> On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
>> - /*
>> - * Ask OP-TEE to free all cached shared memory objects to decrease
>> - * reference counters and also avoid wild pointers in secure world
>> - * into the old shared memory range.
>> - */
>> - optee_disable_shm_cache(optee);
>> + if (shutdown) {
>> + optee_disable_shm_cache(optee);
>> + } else {
>> + /*
>> + * Ask OP-TEE to free all cached shared memory
>> + * objects to decrease reference counters and
>> + * also avoid wild pointers in secure world
>> + * into the old shared memory range.
>> + */
>> + optee_disable_shm_cache(optee);
>
> Calling optee_disable_shm_cache() in both if and else. It could be
> put in front of if().
>
Ideally, I could just use optee_remove for shutdown() too.
But it would not look good. Hence this approach.
- Allen
next prev parent reply other threads:[~2021-02-22 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 9:27 [PATCH 0/2] optee: fix OOM seen due to tee_shm_free() Allen Pais
2021-02-17 9:27 ` [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot Allen Pais
2021-02-18 20:03 ` Dhananjay Phadke
2021-02-22 12:45 ` Allen Pais [this message]
2021-02-23 8:19 ` Jens Wiklander
2021-02-23 16:26 ` Allen Pais
2021-02-24 8:15 ` Jens Wiklander
2021-02-24 16:53 ` Allen Pais
2021-02-17 9:27 ` [PATCH 2/2] firmware: tee_bnxt: implement shutdown method to handle kexec reboots Allen Pais
2021-02-18 18:12 ` [PATCH 0/2] optee: fix OOM seen due to tee_shm_free() Dhananjay Phadke
2021-02-23 6:17 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=allen.lkml@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dphadke@linux.microsoft.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox