From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D972C433E6 for ; Mon, 22 Feb 2021 12:48:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC02064ED6 for ; Mon, 22 Feb 2021 12:48:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbhBVMr0 (ORCPT ); Mon, 22 Feb 2021 07:47:26 -0500 Received: from linux.microsoft.com ([13.77.154.182]:40572 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbhBVMpz (ORCPT ); Mon, 22 Feb 2021 07:45:55 -0500 Received: from [192.168.0.114] (unknown [49.207.208.227]) by linux.microsoft.com (Postfix) with ESMTPSA id D5C6B20B6C40; Mon, 22 Feb 2021 04:45:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D5C6B20B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1613997914; bh=0cItSrOHNyqAnHmYlMTDJGOB4+40TVteNywMP5altWI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=S3opWeTuHjAN4qY/hX6uq5/M2WjhFUhmr0tuz2c0Py7eyP7QBLEFjbQHSe5KTYoEG qg2ou051HmRjivkRNBMs5ii9KUYdRE4ur3owyF1Hqr9aqEwUuOQ/yDQZS2cx0CvTy6 SJTC53nhIk598tm7DvObgpudGc3MEObOHOwwZNzA= Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot To: Dhananjay Phadke , allen.lkml@gmail.com, jens.wiklander@linaro.org, zajec5@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com References: <20210217092714.121297-2-allen.lkml@gmail.com> <20210217092714.121297-2-allen.lkml@gmail.com> From: Allen Pais Message-ID: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com> Date: Mon, 22 Feb 2021 18:15:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210217092714.121297-2-allen.lkml@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org > On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote: >> - /* >> - * Ask OP-TEE to free all cached shared memory objects to decrease >> - * reference counters and also avoid wild pointers in secure world >> - * into the old shared memory range. >> - */ >> - optee_disable_shm_cache(optee); >> + if (shutdown) { >> + optee_disable_shm_cache(optee); >> + } else { >> + /* >> + * Ask OP-TEE to free all cached shared memory >> + * objects to decrease reference counters and >> + * also avoid wild pointers in secure world >> + * into the old shared memory range. >> + */ >> + optee_disable_shm_cache(optee); > > Calling optee_disable_shm_cache() in both if and else. It could be > put in front of if(). > Ideally, I could just use optee_remove for shutdown() too. But it would not look good. Hence this approach. - Allen