From: Florian Fainelli <florian@openwrt.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Jonas Gorski <jonas.gorski@gmail.com>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
John Crispin <blogic@openwrt.org>,
Maxime Bizon <mbizon@freebox.fr>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BCM6358
Date: Mon, 29 Oct 2012 12:10:49 +0100 [thread overview]
Message-ID: <90103311.eQkKdLBACa@flexo> (raw)
In-Reply-To: <508E60DB.6050005@mvista.com>
On Monday 29 October 2012 14:56:27 Sergei Shtylyov wrote:
> Hello.
>
> On 28-10-2012 17:17, Jonas Gorski wrote:
>
> > The softreset register description for BCM6358 was missing, so add it.
>
> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> > ---
> > arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
>
> > diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> > index 12963d0..e84e602 100644
> > --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> > +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> [...]
> > @@ -244,6 +245,15 @@
> > SOFTRESET_6348_ACLC_MASK | \
> > SOFTRESET_6348_ADSLMIPSPLL_MASK)
> >
> > +#define SOFTRESET_6358_SPI_MASK (1 << 0)
> > +#define SOFTRESET_6358_ENET_MASK (1 << 2)
> > +#define SOFTRESET_6358_MPI_MASK (1 << 3)
> > +#define SOFTRESET_6358_EPHY_MASK (1 << 6)
> > +#define SOFTRESET_6358_SAR_MASK (1 << 7)
> > +#define SOFTRESET_6358_USBH_MASK (1 << 12)
> > +#define SOFTRESET_6358_PCM_MASK (1 << 13)
> > +#define SOFTRESET_6358_ADSL_MASK (1 << 14)
> > +
>
> Why not use BIT(n) instead of (1 << n)?
All other bcm63xx headers consistently use (1 << n), I would rather we keep
this convention.
--
Florian
next prev parent reply other threads:[~2012-10-29 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 13:17 [PATCH 0/3] add a reset helper for resetting cores Jonas Gorski
2012-10-28 13:17 ` [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BCM6358 Jonas Gorski
2012-10-29 10:56 ` Sergei Shtylyov
2012-10-29 11:10 ` Florian Fainelli [this message]
2012-10-28 13:17 ` [PATCH 2/3] MIPS: BCM63XX: add core reset helper Jonas Gorski
2012-10-28 13:17 ` [PATCH 3/3] MIPS: BCM63XX: use the new " Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90103311.eQkKdLBACa@flexo \
--to=florian@openwrt.org \
--cc=blogic@openwrt.org \
--cc=cernekee@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox