* [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards
@ 2023-02-20 11:30 Keguang Zhang
2023-02-20 12:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Keguang Zhang @ 2023-02-20 11:30 UTC (permalink / raw)
To: linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski,
Jiaxun Yang, Keguang Zhang
Add two Loongson-1 based boards: LSGZ 1B and Smartloongson 1C.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
.../devicetree/bindings/mips/loongson/devices.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index f13ce386f42c..6ed6e8d1c0a6 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -37,6 +37,16 @@ properties:
items:
- const: loongson,loongson64v-4core-virtio
+ - description: LSGZ 1B Development Board
+ items:
+ - const: lsgz,1b
+ - const: loongson,ls1b
+
+ - description: Smart Loongson 1C Board
+ items:
+ - const: smartloongson,1c
+ - const: loongson,ls1c
+
additionalProperties: true
...
base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards
2023-02-20 11:30 [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards Keguang Zhang
@ 2023-02-20 12:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-20 12:36 UTC (permalink / raw)
To: Keguang Zhang, linux-mips, devicetree, linux-kernel
Cc: Thomas Bogendoerfer, Rob Herring, Krzysztof Kozlowski,
Jiaxun Yang
On 20/02/2023 12:30, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloongson 1C.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> .../devicetree/bindings/mips/loongson/devices.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..6ed6e8d1c0a6 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,16 @@ properties:
> items:
> - const: loongson,loongson64v-4core-virtio
>
> + - description: LSGZ 1B Development Board
> + items:
> + - const: lsgz,1b
1. Undocumented vendor prefix
2. This should be rather enum as it will grow with more boards. Also
description could be rather - LS1B based boards.
> + - const: loongson,ls1b
> +
> + - description: Smart Loongson 1C Board
> + items:
> + - const: smartloongson,1c
Same comments.
> + - const: loongson,ls1c
> +
> additionalProperties: true
>
> ...
>
> base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 11:30 [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards Keguang Zhang
2023-02-20 12:36 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).