From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8EF513B7A0 for ; Thu, 29 Feb 2024 15:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220543; cv=none; b=kvVrptnE2Z1+tnsnHD4B7A7icPnWOaBBSeQbOdU+Djfws2E2BpzWcv6kY1tt94FIu9vZ7ZEAx3MW9t6R4YnPkTmTqA+eLeX9a+vix6cFLCb0L4Fa1Oe7qn1AKjeBFMpGFdQ4YB5o30Uoi1RZ569TIdIrK7cLYf9KCsc7ug5ppRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220543; c=relaxed/simple; bh=GS6Azpxv+L3XEIbmLWsr0WYp0WE3bOEpnYP5dcCSHOw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jwlPN4dBDdkweoXNl1pk3ClsJDts5RexJrRu2KjEeCGhEgzZwCeocZBEiEjTMSlph0sEaT36haaMXsQ9ZMVIFKVU/Y0/KLiSRJN6q/vq6BThzbgF345eMcMsY8F8bvPQqEkPJaVZxavU8HCGguBPkBzUHqwysWpn4Ww+bFjIXi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfiKz-0006iF-40; Thu, 29 Feb 2024 16:28:45 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rfiKx-003c9I-7C; Thu, 29 Feb 2024 16:28:43 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1rfiKx-000Bqn-0S; Thu, 29 Feb 2024 16:28:43 +0100 Message-ID: <959414f110463d5de87c84a986c7894a03afcf4e.camel@pengutronix.de> Subject: Re: [PATCH v8 04/10] reset: eyeq5: add platform driver From: Philipp Zabel To: Andy Shevchenko , =?ISO-8859-1?Q?Th=E9o?= Lebrun Cc: Gregory CLEMENT , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Linus Walleij , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Vladimir Kondratiev , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk , linux-gpio@vger.kernel.org Date: Thu, 29 Feb 2024 16:28:42 +0100 In-Reply-To: References: <20240227-mbly-clk-v8-0-c57fbda7664a@bootlin.com> <20240227-mbly-clk-v8-4-c57fbda7664a@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org On Do, 2024-02-29 at 15:48 +0200, Andy Shevchenko wrote: > On Thu, Feb 29, 2024 at 01:18:08PM +0100, Th=C3=A9o Lebrun wrote: > > On Thu Feb 29, 2024 at 12:22 PM CET, Andy Shevchenko wrote: > > > On Wed, Feb 28, 2024 at 06:04:47PM +0100, Th=C3=A9o Lebrun wrote: > > > > On Tue Feb 27, 2024 at 6:27 PM CET, Andy Shevchenko wrote: > > > > > On Tue, Feb 27, 2024 at 03:55:25PM +0100, Th=C3=A9o Lebrun wrote: >=20 > ... >=20 > > > > > > + priv->rcdev.of_node =3D np; > > > > >=20 > > > > > It's better to use device_set_node(). > > > >=20 > > > > I don't see how device_set_node() can help? It works on struct devi= ce > > > > pointers. Here priv->rcdev is a reset_controller_dev struct. There = are > > > > no users of device_set_node() in drivers/reset/. > > >=20 > > > No users doesn't mean it's good. The API is relatively "new" and take= s > > > care of two things: > > > 1) it uses agnostic interface; > > > 2) it doesn't require any firmware node direct dereference. > > >=20 > > > The 2) is most important here as allows us to refactor (firmware node= ) code > > > in the future. > >=20 > > I think I get the point of device_set_node(). I still do not understand > > how it could help me fill the ->of_node field in a reset_controller_dev > > structure? >=20 > Exactly why I put the above comment as recommendation. And then I elabora= ted > that entire reset framework should rather move towards fwnode. For context, there have been initial patches for this, that turned out not to be necessary later on: https://lore.kernel.org/lkml/20220324141237.297207-1-clement.leger@bootlin.= com/ At this point, there still is no real use case for non-DT reset controls on the horizon. >=20 regards Philipp