From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD60819005E for ; Mon, 6 Jul 2026 00:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783298066; cv=none; b=hU4UGj5kV6/D8Wh/PBLunSwipHSo8JWTOBEfY13BuquvcxtWJPiJzgjLlGUW/qoG88G/5YVvHbbnvUuw2zjhck8Fe0tTg7FzmYwPEHP6N1QOToyniucZG5MeironUUgcs4bVMkbZ8aVl1zG06+ymYCItIi7UmSib2Ws2GClvgEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783298066; c=relaxed/simple; bh=2PxUxZPMKUCuY9XPy73Y/KPmQ0r97rw0cg10OraDCjk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u5I/Di3CHlZbA7LovKkJ6c6pFIiaYqvFDgoy6Uxxpnn1s3mUYZ3Nc2jyUBBeh2SfU1aKGr5zBRpQPXtA9QWT0GBg6tFFoyqrtiPWCLBtIlA+UAHFroc2/YlNp8PZHBYNmZPT0HpmLTUQWh0JK0VHyRMJywP/FxyFyvhbK0F0UEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mLsuUED9; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mLsuUED9" Message-ID: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783298059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wYrjdzAhnc0P88BFwUH/b6uj52WFQfIRb2R1u4QFCds=; b=mLsuUED9ENIp3ed3h8bdKFYcEwFgoRzOELLNc1jLIXF6taZ+WEztXLwd9/BAKQWvUz2Hs3 3EKLIatmB5Z+Df3dgdlCr8bmpTJQbWFj3Jp6WCvzaQnW40BXVB4LUsJRj7jQdhncagFIYu oCbFYryMjDBm1fu5il4d+x3rl9gBRyM= Date: Mon, 6 Jul 2026 08:33:47 +0800 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , linux-pwm@vger.kernel.org Cc: Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chen Wang In-Reply-To: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote: > - Use a single space in a of_device_id array terminator; A single space > after the opening { and before the closing } in non-empty > initializers; > - No comma after an array terminator; > - Also no trailing comma after a named initializer iff the iff -> if > closing } is on the same line; > > Signed-off-by: Uwe Kleine-König (The Capable Hub) [......] > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c > index 7d07b0ca7d29..0b6461172e6a 100644 > --- a/drivers/pwm/pwm-sophgo-sg2042.c > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_data = { > static const struct of_device_id sg2042_pwm_ids[] = { > { > .compatible = "sophgo,sg2042-pwm", > - .data = &sg2042_chip_data > - }, > - { > + .data = &sg2042_chip_data, > + }, { > .compatible = "sophgo,sg2044-pwm", > - .data = &sg2044_chip_data > + .data = &sg2044_chip_data, > }, > { } > }; Changes to sophgo related files： Reviewed-by: Chen Wang Thanks, Chen [......]