From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799C1C0044D for ; Mon, 16 Mar 2020 13:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5664020658 for ; Mon, 16 Mar 2020 13:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731330AbgCPNe4 (ORCPT ); Mon, 16 Mar 2020 09:34:56 -0400 Received: from foss.arm.com ([217.140.110.172]:48402 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731351AbgCPNe4 (ORCPT ); Mon, 16 Mar 2020 09:34:56 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31D61FEC; Mon, 16 Mar 2020 06:34:55 -0700 (PDT) Received: from [10.37.9.38] (unknown [10.37.9.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9C093F52E; Mon, 16 Mar 2020 06:34:49 -0700 (PDT) Subject: Re: [PATCH v3 18/26] arm64: Introduce asm/vdso/processor.h To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Will Deacon , Arnd Bergmann , Russell King , Paul Burton , Thomas Gleixner , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Stephen Boyd , Mark Salyzyn , Kees Cook , Peter Collingbourne , Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Nick Desaulniers , Marc Zyngier , Mark Rutland , Will Deacon References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-19-vincenzo.frascino@arm.com> <20200315182950.GB32205@mbp> <20200316103437.GD3005@mbp> <77a2e91a-58f4-3ba3-9eef-42d6a8faf859@arm.com> <20200316112205.GE3005@mbp> From: Vincenzo Frascino Message-ID: <9a0a9285-8a45-4f65-3a83-813cabd0f0d3@arm.com> Date: Mon, 16 Mar 2020 13:35:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200316112205.GE3005@mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Catalin, On 3/16/20 11:22 AM, Catalin Marinas wrote: > On Mon, Mar 16, 2020 at 10:55:00AM +0000, Vincenzo Frascino wrote: >> On 3/16/20 10:34 AM, Catalin Marinas wrote: [...] > > As I said above, I don't see how removing 'if ((u32)ts >= (1UL << 32))' > makes any difference. This check was likely removed by the compiler > already. > > Also, userspace doesn't have a trivial way to figure out TASK_SIZE and I > can't see anything that tests this in the vdsotest (though I haven't > spent that much time looking). If it's hard-coded, note that arm32 > TASK_SIZE is different from TASK_SIZE_32 on arm64. > > Can you tell what actually is failing in vdsotest if you remove the > TASK_SIZE_32 checks in the arm64 compat vdso? > To me does not seem optimized out. Which version of the compiler are you using? Please find below the list of errors for clock_gettime (similar for the other): passing UINTPTR_MAX to clock_gettime (VDSO): terminated by unexpected signal 7 clock-gettime-monotonic/abi: 1 failures/inconsistencies encountered passing UINTPTR_MAX to clock_gettime (VDSO): terminated by unexpected signal 7 clock-gettime-monotonic-coarse/abi: 1 failures/inconsistencies encountered passing UINTPTR_MAX to clock_gettime (VDSO): terminated by unexpected signal 7 clock-gettime-realtime/abi: 1 failures/inconsistencies encountered passing UINTPTR_MAX to clock_gettime (VDSO): terminated by unexpected signal 7 clock-gettime-realtime-coarse/abi: 1 failures/inconsistencies encountered Please refer to [1] for more details on the test. [1] https://github.com/nlynch-mentor/vdsotest/blob/master/src/clock_gettime_template.c -- Regards, Vincenzo